Skip to content

Rustup https://github.com/rust-lang/rust/pull/58689#160

Merged
laumann merged 1 commit into
Manishearth:masterfrom
mati865:rustup
Mar 3, 2019
Merged

Rustup https://github.com/rust-lang/rust/pull/58689#160
laumann merged 1 commit into
Manishearth:masterfrom
mati865:rustup

Conversation

@mati865

@mati865 mati865 commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Fix for the next (not yet released) nightly.

Fixes #159

@mati865

mati865 commented Mar 2, 2019

Copy link
Copy Markdown
Contributor Author

Let's make the CI green.

@mati865 mati865 closed this Mar 2, 2019
@mati865 mati865 reopened this Mar 2, 2019
@mati865

mati865 commented Mar 2, 2019

Copy link
Copy Markdown
Contributor Author

Should I add cfg checking for stable feature to this field?

@laumann

laumann commented Mar 3, 2019

Copy link
Copy Markdown
Collaborator

Hi @mati865, thanks for opening this PR!

Should I add cfg checking for stable feature to this field?

Yeah, that looks to be necessary.

@mati865

mati865 commented Mar 3, 2019

Copy link
Copy Markdown
Contributor Author

All green.

@Xanewok

Xanewok commented Mar 3, 2019

Copy link
Copy Markdown

If merged, please do a point release (so that we can fix Clippy and RLS without some of the branch acrobatics required across multiple repositories), thanks!

@laumann

laumann commented Mar 3, 2019

Copy link
Copy Markdown
Collaborator

All green.

Awesome, thanks!

If merged, please do a point release (so that we can fix Clippy and RLS without some of the branch acrobatics required across multiple repositories), thanks!

Will do.

@laumann

laumann commented Mar 3, 2019

Copy link
Copy Markdown
Collaborator

@Xanewok @mati865 Just for me to get the timeline right: When this PR was created, the nightly this fix is inteded for wasn't released yet, but it now, right?

@laumann laumann merged commit 3c92747 into Manishearth:master Mar 3, 2019
@mati865

mati865 commented Mar 3, 2019

Copy link
Copy Markdown
Contributor Author

@Xanewok @mati865 Just for me to get the timeline right: When this PR was created, the nightly this fix is inteded for wasn't released yet, but it now, right?

Exactly.

@mati865 mati865 deleted the rustup branch March 3, 2019 14:45
@laumann

laumann commented Mar 3, 2019

Copy link
Copy Markdown
Collaborator

@Xanewok @mati865 Version 0.3.19 is out!

@Xanewok

Xanewok commented Mar 3, 2019

Copy link
Copy Markdown

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants