Skip to content

spelling: parallell -> parallel#36

Closed
grooverdan wants to merge 5 commits intoMariaDB:10.0from
openquery:spelling-parallell
Closed

spelling: parallell -> parallel#36
grooverdan wants to merge 5 commits intoMariaDB:10.0from
openquery:spelling-parallell

Conversation

@grooverdan
Copy link
Copy Markdown
Member

The parallelizm of 'l's in the word "parallel" has exceeded the english
language specification.

Comments only are affected. storage/ndb had too much parallell in code
to consider fixing.

The parallelizm of 'l's in the word "parallel" has exceeded the english
language specification.

Comments only are affected. storage/ndb had too much parallell in code
to consider fixing.
@grooverdan
Copy link
Copy Markdown
Member Author

cleaned up at targeted at 5.5 in #56

@grooverdan grooverdan closed this Apr 30, 2015
ankitkumar031 pushed a commit to ankitkumar031/server that referenced this pull request Apr 16, 2017
Remove hard-coded value for publishing pulse messages
vuvova pushed a commit that referenced this pull request Jun 22, 2017
* BEGIN_TS(), COMMIT_TS() SQL functions;
* VTQ instead of packed stores secs + usecs like my_timestamp_to_binary() does;
* versioned SELECT to IB is translated with COMMIT_TS();
* SQL fixes:
  - FOR_SYSTEM_TIME_UNSPECIFIED condition compares to TIMESTAMP_MAX_VALUE;
  - segfault fix #36: multiple execute of prepared stmt;
  - different tables to same stored procedure fix (#39)
* Fixes of previous parts: ON DUPLICATE KEY, other misc fixes.
dr-m pushed a commit that referenced this pull request Nov 10, 2017
* BEGIN_TS(), COMMIT_TS() SQL functions;
* VTQ instead of packed stores secs + usecs like my_timestamp_to_binary() does;
* versioned SELECT to IB is translated with COMMIT_TS();
* SQL fixes:
  - FOR_SYSTEM_TIME_UNSPECIFIED condition compares to TIMESTAMP_MAX_VALUE;
  - segfault fix #36: multiple execute of prepared stmt;
  - different tables to same stored procedure fix (#39)
* Fixes of previous parts: ON DUPLICATE KEY, other misc fixes.
midenok pushed a commit that referenced this pull request Apr 20, 2023
…dition_selectivity=4 (#36)

The Cause:
The condition selectivity for a table is calculated in “calculate_cond_selectivity_for_table”
function in sql/opt_range.cc. When calculating selectivity for indexes, the function iterates through
all the used keyparts and calculates selectivity. However, when we have extended keys enabled
and if a primary key part appear in the query in addition to a normal key, the selectivity
for the primary key part is not calculated.

Inside the “calculate_cond_selectivity_for_table” function, when calculate selectivity
for an index the code marks all the key parts of that key as processed.
When extended keys are enabled, the code also marks primary key parts
as processed. This causes primary key based condition selectivities to be not
calculated as the key parts are already marked as handled.

The Fix:
The code is modified to only consider user-defined keyparts when calculating the index selectivity.

Effect on existing test cases:
The following test case results were modified to match the output of the modified code.
        join_cache.result
        opt_trace.result

Signed-off-by: Thejaka Kanewala <thejaka.kanewala@servicenow.com>
midenok pushed a commit that referenced this pull request Apr 20, 2023
…lan with optimizer_use_condition_selectivity=4 (#68)

* Revert "Fixing optimizer code to generate better plans when optimizer_use_condition_selectivity=4 (#36)"

This reverts commit a980cc9.

* PRB1574580: reverting the selectivity fix we did earlier and adding the fix from Maria as it covers more scope of the issue.

* PRB1574580: fixing a syntax error related to mtr result outcome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant