Skip to content
/ server Public

create_new_thread: release LOCK_thread_count#415

Closed
grooverdan wants to merge 1 commit intoMariaDB:5.5from
grooverdan:5.5-coverity-972079
Closed

create_new_thread: release LOCK_thread_count#415
grooverdan wants to merge 1 commit intoMariaDB:5.5from
grooverdan:5.5-coverity-972079

Conversation

@grooverdan
Copy link
Member

Like create_embedded_thd we release the LOCK_thread_count
after it is scheduled.

Found by Coverity id 972079

I submit this under the MCA

Like create_embedded_thd we release the LOCK_thread_count
after it is scheduled.

Found by Coverity id 972079
@svoj svoj added this to the 5.5 milestone Jul 3, 2017
@svoj svoj self-assigned this Jul 3, 2017
@svoj
Copy link
Contributor

svoj commented Jul 3, 2017

Unlock happens in MYSQL_CALLBACK(thd->scheduler, add_connection, (thd)), e.g. see handle_connection_in_main_thread() or create_thread_to_handle_connection. Your unlock is duplicate.

@svoj svoj closed this Jul 3, 2017
@grooverdan grooverdan deleted the 5.5-coverity-972079 branch July 3, 2017 11:53
@grooverdan
Copy link
Member Author

appologies. I should of seen that.

Thanks for the other merges.

vuvova added a commit that referenced this pull request Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants