Merged
Conversation
svoj
requested changes
Jul 6, 2017
Contributor
svoj
left a comment
svoj
left a comment
There was a problem hiding this comment.
my_b_clear() should be enough.
bzero() is generally deprecated and we should use memset.
Contributor
|
And then condition must change to |
Contributor
|
@grooverdan we have 5.5 week now. Please update if you want to get this into next 5.5 release. |
Member
Author
|
thanks for the heads up. |
grooverdan
force-pushed
the
5.5-coverity-maria_repair_parallel
branch
from
0c5b3fd to
b874542
Compare
end_io_call uses uninitialized values from the new_data_cache As such we the buffer 0 and check this before calling end_io_cache on it. Thanks Sergey Vojtovich for the review and for this solution. Found by Coverity (ref 972481).
grooverdan
force-pushed
the
5.5-coverity-maria_repair_parallel
branch
from
b874542 to
44d74a7
Compare
svoj
reviewed
Jul 18, 2017
| */ | ||
| DBUG_PRINT("info", ("is quick repair: %d", (int) rep_quick)); | ||
| if (!rep_quick) | ||
| my_b_clear(&new_data_cache); |
Contributor
There was a problem hiding this comment.
Taking into account simplicity of my_b_clear() and my_b_inited() I'd rather do my_b_clear() unconditionally. It saves 2 conditional jumps, which performance wise are worse than single unconditional store.
This is just to voice my opinion, current implementation is generally fine too. No action needed.
Contributor
|
Thanks! |
Member
Author
|
works for me. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I submit this under the MCA.