Fixes MDEV-7658: MDEV-7026 fix reintroduces MDEV-6615 on AArch64#73
Merged
svoj merged 1 commit intoMariaDB:5.5from May 27, 2015
Merged
Fixes MDEV-7658: MDEV-7026 fix reintroduces MDEV-6615 on AArch64#73svoj merged 1 commit intoMariaDB:5.5from
svoj merged 1 commit intoMariaDB:5.5from
Conversation
This is an addendum to the fix for MDEV-7026. The ARM memory model is similar to that of PowerPC and thus needs the same semantics with respect to memory barriers. That is, os_atomic_test_and_set_*_release() must be a store with a release barrier followed by a full barrier. Unlike x86 using __sync_lock_test_and_set() which is implemented as “exclusive load with acquire barriers + exclusive store” is insufficient in contexts where os_atomic_test_and_set_*_release() macros are used.
Contributor
|
Great! Thanks for fixing this. |
svoj
added a commit
that referenced
this pull request
May 27, 2015
Fixes MDEV-7658: MDEV-7026 fix reintroduces MDEV-6615 on AArch64
ankitkumar031
pushed a commit
to ankitkumar031/server
that referenced
this pull request
Apr 16, 2017
Adding handler for triggering talos jobs twice on PGO builds
vuvova
pushed a commit
that referenced
this pull request
Jun 22, 2017
dr-m
pushed a commit
that referenced
this pull request
Nov 10, 2017
spetrunia
pushed a commit
that referenced
this pull request
Mar 19, 2020
Better behavior with offline cluster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an addendum to the fix for MDEV-7026. The ARM memory model is
similar to that of PowerPC and thus needs the same semantics with
respect to memory barriers. That is, os_atomic_test_and_set___release()
must be a store with a release barrier followed by a full
barrier. Unlike x86 using __sync_lock_test_and_set() which is
implemented as “exclusive load with acquire barriers + exclusive store”
is insufficient in contexts where os_atomic_test_and_set___release()
macros are used.