Skip to content

mcp: add integration tests#35540

Merged
bobbyiliev merged 1 commit intoMaterializeInc:mainfrom
bobbyiliev:mcp-integration-tests
Mar 24, 2026
Merged

mcp: add integration tests#35540
bobbyiliev merged 1 commit intoMaterializeInc:mainfrom
bobbyiliev:mcp-integration-tests

Conversation

@bobbyiliev
Copy link
Contributor

@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@bobbyiliev bobbyiliev force-pushed the mcp-integration-tests branch 5 times, most recently from 83ef9ed to 5ada0a5 Compare March 19, 2026 14:24
@bobbyiliev bobbyiliev force-pushed the mcp-integration-tests branch from 5ada0a5 to cb2293e Compare March 19, 2026 14:50
@bobbyiliev bobbyiliev marked this pull request as ready for review March 19, 2026 15:09
@bobbyiliev bobbyiliev requested a review from a team as a code owner March 19, 2026 15:09
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have context on the rest of this change, but this change here seems fine to me...

Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we'd gain anything from testing from outside of cargo test. How slow is the cargo test execution btw?

@bobbyiliev
Copy link
Contributor Author

I'm wondering if we'd gain anything from testing from outside of cargo test. How slow is the cargo test execution btw?

@def- ah yes good idea! The cargo tests run in-process so an external e2e test would definitely cover different ground. Will do a follow-up PR for that.

For cargo test speed, tests take about 3-9s each in CI:

PASS [   3.218s] (146/239) mz-environmentd::server test_mcp_agents_disabled
PASS [   5.302s] (147/239) mz-environmentd::server test_mcp_agents
PASS [   3.467s] (148/239) mz-environmentd::server test_mcp_agents_runtime_flag_toggle
PASS [   4.171s] (149/239) mz-environmentd::server test_mcp_agents_query_tool
PASS [   3.624s] (150/239) mz-environmentd::server test_mcp_observatory
PASS [   8.199s] (153/239) mz-environmentd::server test_mcp_agents_rbac
PASS [   9.025s] (156/239) mz-environmentd::server test_mcp_agents_with_data_product

@bobbyiliev bobbyiliev merged commit ec9d159 into MaterializeInc:main Mar 24, 2026
126 checks passed
bobbyiliev added a commit that referenced this pull request Mar 24, 2026
As suggested here:
#35540 (review)
adding mzcompose-based e2e tests that exercise the MCP agents and
observatory HTTP endpoints, complementing the existing in-process cargo
tests.
antiguru pushed a commit to antiguru/materialize that referenced this pull request Mar 26, 2026
…c#35602)

As suggested here:
MaterializeInc#35540 (review)
adding mzcompose-based e2e tests that exercise the MCP agents and
observatory HTTP endpoints, complementing the existing in-process cargo
tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants