mcp: add integration tests#35540
Merged
bobbyiliev merged 1 commit intoMaterializeInc:mainfrom Mar 24, 2026
Merged
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
83ef9ed to
5ada0a5
Compare
5ada0a5 to
cb2293e
Compare
mtabebe
reviewed
Mar 20, 2026
Contributor
There was a problem hiding this comment.
I don't really have context on the rest of this change, but this change here seems fine to me...
def-
approved these changes
Mar 20, 2026
Contributor
def-
left a comment
There was a problem hiding this comment.
I'm wondering if we'd gain anything from testing from outside of cargo test. How slow is the cargo test execution btw?
Contributor
Author
@def- ah yes good idea! The cargo tests run in-process so an external e2e test would definitely cover different ground. Will do a follow-up PR for that. For cargo test speed, tests take about 3-9s each in CI: |
bobbyiliev
added a commit
that referenced
this pull request
Mar 24, 2026
As suggested here: #35540 (review) adding mzcompose-based e2e tests that exercise the MCP agents and observatory HTTP endpoints, complementing the existing in-process cargo tests.
antiguru
pushed a commit
to antiguru/materialize
that referenced
this pull request
Mar 26, 2026
antiguru
pushed a commit
to antiguru/materialize
that referenced
this pull request
Mar 26, 2026
…c#35602) As suggested here: MaterializeInc#35540 (review) adding mzcompose-based e2e tests that exercise the MCP agents and observatory HTTP endpoints, complementing the existing in-process cargo tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://linear.app/materializeinc/issue/DEX-5/mcp-integration-tests