Fix photo sketching bugs#4052
Merged
tomasMizera merged 4 commits intodev/2025.6.0from Aug 27, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 17262432346Details
💛 - Coveralls |
tomasMizera
approved these changes
Aug 26, 2025
tomasMizera
reviewed
Aug 27, 2025
| { | ||
| QDir::temp().remove( photoFileName ); | ||
| mPhotoSource = QUrl( QDir::temp().absolutePath() + "/" + photoFileName ).toString(); | ||
| emit tempPhotoSourceChanged( QUrl( mPhotoSource ).toString() ); |
Collaborator
There was a problem hiding this comment.
Can we cover this case in unit tests please?
Contributor
Author
There was a problem hiding this comment.
sure, check latest commit
tomasMizera
approved these changes
Aug 27, 2025
Withalion
added a commit
that referenced
this pull request
Sep 2, 2025
* Fix photo sketching crash on resketching * Fix bottom padding on photo sketching page * Fix vanishing sketches on long forms * Add tests for image loading in PhotoSketchingController
tomasMizera
added a commit
that referenced
this pull request
Sep 3, 2025
* Update version * Update apple CI (#4043) * Switch workspace on invitation accepted (#3895) --------- Co-authored-by: Withalion <bagarmatej@gmail.com> * Photo sketching support (#3930) * Fix out of date server dialog (#4051) * Photo sketching improvement (#4049) * Add test for clearOrientationMetadata ImageUtil * Refactor TestImageUtils * Make photo sketching opt-in * Add photosketching tests * Fix formatting * Fix photo sketching bugs (#4052) * Fix photo sketching crash on resketching * Fix bottom padding on photo sketching page * Fix vanishing sketches on long forms * Add tests for image loading in PhotoSketchingController * Change CI to build AAB on dev branches * Fix photo sketching bugs (#4065) --------- Co-authored-by: Vitor Vieira <155513369+VitorVieiraZ@users.noreply.github.com>
tomasMizera
pushed a commit
that referenced
this pull request
Sep 3, 2025
* Fix photo sketching crash on resketching * Fix bottom padding on photo sketching page * Fix vanishing sketches on long forms * Add tests for image loading in PhotoSketchingController
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.