Standardize CDP SQL numeric schemas#874
Open
LeeSee1999 wants to merge 1 commit into
Open
Conversation
Contributor
|
@LeeSee1999 is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45.
Summary
cdpSqlNumberSchemaandcdpSqlIntegerSchemahelpers for CDP SQL aggregate responses.numbervalues.total_amountconversion in bucketed transfer stats now that the result schema handles the coercion consistently.Verification
git diff --checkpnpm exec prettier --check <changed transfer service files>pnpm --filter @x402scan/app types:checkwas attempted locally. It currently fails before a clean app check because the local checkout is missing generated Prisma/Next/workspace type artifacts and reports existing project-wide type errors outside this change. I filtered the output for the modifiedsrc/services/transferspaths and did not find errors from this patch.