Add support for monsoon 3 #166
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @james-bruten-mo
Code Reviewer: @r-sharp
This is based on the changes in trac ticket #779. It also enables github personal access tokens by default on monsoon and defines an additional EX1A_WEIGHTS group to prevent undefined parent errors when running the ex1a group on monsoon.
Code Quality Checklist
Testing
Test suite also run on the monsoon 3 partition. Build tasks passed as expected, as did a number of model runs. Some test runs failed due to known problems with missing files in
$BIG_DATA_DIR.trac.log
Test Suite Results - lfric_apps - monsoon-branch/run1
Suite Information
Task Information
✅ succeeded tasks - 1106
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review