Feat/landing by tommymaher15 · Pull Request #1018 · MetaFam/TheGame

tommymaher15 · 2022-01-05T01:40:33Z

Overview

What features/fixes does this PR include?

Added each component as per the mockup for the initial design.

Mockups are only for Desktop that I could see so not responsive yet but a starting point.

Will be tidying up and making things cleaner now that things are finished.

Please provide the GitHub issue number

Closes #

Follow up Improvement Ideas

please list any improvement/ideas

Implementation

Describe technical (nontrivial / non-obvious) parts of your code

Side effects

Assets

[Include screenshots/videos if it makes reviewing easier.]

testing

vercel · 2022-01-05T01:43:42Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/metafam/the-game/8vxtf99WvuNUV8dXRgAqkrTHeBZQ
✅ Preview: https://the-game-git-feat-landing-metafam.vercel.app

testing

vidvidvid · 2022-01-14T16:37:53Z

Thanks. The build is failing on this latest update for some reason.

same thing happened here: #1014 and i retriggered the deploy which was then successful. idk what's the deal with vercel, but this is getting pretty annoying :'D

Gnomeski · 2022-01-14T16:46:48Z

"For those who want to: Help finding tools, frameworks & funds accessible. Help getting value-aligned contributors & adopters. Become a part of the "new world" puzzle."

Is this meant to be those who want (no 'to' here?) - help finding tools, frameworks and accessible funds (reverse words). Also it can just be "become part of" no need for the a.

dan13ram · 2022-01-15T15:46:34Z

packages/web/components/Landing/sections/Build.tsx

+      flexDirection="column"
+      justifyContent="center"
+      maxWidth="100%"
+      pl={{ base: '0', md: '137px' }}


Hey there's still places where px is used, which can be replaced with rem equivalents, like this one.

dan13ram · 2022-01-15T15:47:55Z

packages/web/components/Landing/sections/Together.tsx

+        bgClip="text"
+        maxWidth="75rem"
+        display="inline"
+        pb="35px"


here too, and also paddings in the Text components inside this Box

dan13ram · 2022-01-15T15:50:13Z

packages/web/components/Landing/sections/Unplug.tsx

+        color="white"
+        maxWidth="75rem"
+      >
+        <Text pt="130px" pb="35px" textAlign="center">


Here also padding

dan13ram · 2022-01-15T15:51:22Z

packages/web/components/Landing/sections/WhatWeDo.tsx

+    >
+      <Box
+        fontSize={{ base: '1.5rem', md: '3rem' }}
+        lineHeight={{ base: '2.25rem', md: '4rem' }}


paddings and maxWidth here

dan13ram

Mostly looks good. We can merge now but we should work on moving these px measurements to rem equivalents so that everything remains responsive :)

dan13ram · 2022-01-15T15:53:36Z

packages/web/components/Landing/sections/Cards.tsx

+        display="flex"
+        alignItems="center"
+        flexDirection="column"
+        pl="76px"


on this page there are many paddings, widths, and particularly fontSize is in pxs. We want to replace them with rem equivalents and the fontSize to sm, md, lg or xl as necessary

perfect I've fixed all of these to rem. Apologies I missed out on those others.

peth-yursick · 2022-01-15T20:48:47Z

I am a tiiiny bit cringed out by the "Join NAO" in the very beginning to be totally honest.
I get a sense of dissonance between this "lolcats"-type of writing in the beginning and the rest of the text and aesthetic which seem to be quite serious afterwards.
This might be an aesthetic choice but I think it may probably drive other people off too, especially if we now want to appeal to more academically inclined audiences such as Game B folks.

This kind of "we're doing serious things but we also joke" vibe has kind of been the brand voice since the first articles. Personally, I find things more believable with this "we don't take ourselves too seriously" vibe vs. being super serious, especially if talking about something utopian.
To me, making it serious is what makes it cringe..

In this case, the right way to go may simply be to remove the "join nao". Its kind of a standard practice to have the call to action right away but in our case I think it might be better to force everyone to actually read the page before trying to join 🤷‍♂️

But this may be just me & it really is time to solidify brand voice..
Thank you for the feedback 🙏

This reverts commit 53d9871.

* Create landing.tsx testing * feat:Intro section (initial) * feat:Intro section (cleanup) * feat:Intro section (initial) * Landing: Added second section and necessary assets * Landing: Added second section and necessary assets * Landing: cleanup intro * Landing: Build section done * Landing: added revolution section. Apologies on naming 🚀 * Big commit: added multiple sections & some minor fixes * small ui fixed * Final push on last components next commit * ui fix * large commit: added most final sections, one more to go * added all sections as per mockup.Up next: refactoring and cleanup * testing * Create landing.tsx testing * feat:Intro section (initial) * feat:Intro section (cleanup) * feat:Intro section (initial) * Landing: Added second section and necessary assets * Landing: Added second section and necessary assets * Landing: cleanup intro * Landing: Build section done * Landing: added revolution section. Apologies on naming 🚀 * Big commit: added multiple sections & some minor fixes * small ui fixed * Final push on last components next commit * ui fix * large commit: added most final sections, one more to go * added all sections as per mockup.Up next: refactoring and cleanup * testing * cleanup file structure * feat: landing ( Improved file structure for landing page and tidied improrts * fixed imports: importing from design system instead from chakra * fixed ordered list * cleanup * fixed ordered list * Update packages/web/pages/landing.tsx Co-authored-by: vidvidvid <35112939+vidvidvid@users.noreply.github.com> * prettier and cleanup folders * testing type declaration * big commit: fixed missing type errors and linting errors * removed px values + rem (used colors as per design system ) * updated node modules * updated imports * mobile work: WIP * more mobile work * responsiveness changes for last components * fix * Trigger Build * updated intro to fix overlap * fixed height on sections to full height * quickfix * Trigger Build * content change * content changes * fixed exports on components and imports as per linting guidelines ) * fixed px values to rem for responsiveness Co-authored-by: vidvidvid <35112939+vidvidvid@users.noreply.github.com>

This reverts commit 53d9871.

* Create landing.tsx testing * feat:Intro section (initial) * feat:Intro section (cleanup) * feat:Intro section (initial) * Landing: Added second section and necessary assets * Landing: Added second section and necessary assets * Landing: cleanup intro * Landing: Build section done * Landing: added revolution section. Apologies on naming 🚀 * Big commit: added multiple sections & some minor fixes * small ui fixed * Final push on last components next commit * ui fix * large commit: added most final sections, one more to go * added all sections as per mockup.Up next: refactoring and cleanup * testing * Create landing.tsx testing * feat:Intro section (initial) * feat:Intro section (cleanup) * feat:Intro section (initial) * Landing: Added second section and necessary assets * Landing: Added second section and necessary assets * Landing: cleanup intro * Landing: Build section done * Landing: added revolution section. Apologies on naming 🚀 * Big commit: added multiple sections & some minor fixes * small ui fixed * Final push on last components next commit * ui fix * large commit: added most final sections, one more to go * added all sections as per mockup.Up next: refactoring and cleanup * testing * cleanup file structure * feat: landing ( Improved file structure for landing page and tidied improrts * fixed imports: importing from design system instead from chakra * fixed ordered list * cleanup * fixed ordered list * Update packages/web/pages/landing.tsx Co-authored-by: vidvidvid <35112939+vidvidvid@users.noreply.github.com> * prettier and cleanup folders * testing type declaration * big commit: fixed missing type errors and linting errors * removed px values + rem (used colors as per design system ) * updated node modules * updated imports * mobile work: WIP * more mobile work * responsiveness changes for last components * fix * Trigger Build * updated intro to fix overlap * fixed height on sections to full height * quickfix * Trigger Build * content change * content changes * fixed exports on components and imports as per linting guidelines ) * fixed px values to rem for responsiveness Co-authored-by: vidvidvid <35112939+vidvidvid@users.noreply.github.com>

This reverts commit 53d9871.

tommymaher15 added 16 commits December 11, 2021 21:09

Create landing.tsx

8a50d24

testing

feat:Intro section (initial)

4be6db4

feat:Intro section (cleanup)

5b1febc

feat:Intro section (initial)

c9852d1

Landing: Added second section and necessary assets

8793555

Landing: Added second section and necessary assets

780feb4

Landing: cleanup intro

535aec7

Landing: Build section done

c59ad93

Landing: added revolution section. Apologies on naming 🚀

e4f8a4a

Big commit: added multiple sections & some minor fixes

84f63b2

small ui fixed

4c79421

Final push on last components next commit

c8e6f6b

ui fix

93e00e1

large commit: added most final sections, one more to go

94c0d7d

added all sections as per mockup.Up next: refactoring and cleanup

21ce445

testing

904c533

vercel bot deployed to Preview January 5, 2022 01:43 View deployment

tommymaher15 added 12 commits January 5, 2022 01:47

Create landing.tsx

be774bf

testing

feat:Intro section (initial)

464c301

feat:Intro section (cleanup)

31a962f

feat:Intro section (initial)

7224359

Landing: Added second section and necessary assets

531e000

Landing: Added second section and necessary assets

deaa297

Landing: cleanup intro

c878d17

Landing: Build section done

102d7f6

Landing: added revolution section. Apologies on naming 🚀

93e2887

Big commit: added multiple sections & some minor fixes

b66ca71

small ui fixed

3c53ba0

Final push on last components next commit

785abde

Trigger Build

7a9dc6b

vercel bot deployed to Preview January 14, 2022 16:30 View deployment

content change

c4cd974

vercel bot deployed to Preview January 15, 2022 12:33 View deployment

content changes

118cc78

vidvidvid approved these changes Jan 15, 2022

View reviewed changes

vercel bot deployed to Preview January 15, 2022 13:03 View deployment

fixed exports on components and imports as per linting guidelines )

f966257

vercel bot deployed to Preview January 15, 2022 14:17 View deployment

dan13ram reviewed Jan 15, 2022

View reviewed changes

dan13ram approved these changes Jan 15, 2022

View reviewed changes

fixed px values to rem for responsiveness

8532dd7

vercel bot deployed to Preview January 15, 2022 16:42 View deployment

vidvidvid merged commit 53d9871 into develop Jan 15, 2022

vidvidvid deleted the feat/landing branch January 15, 2022 17:33

vidvidvid mentioned this pull request Jan 15, 2022

Next iteration of landing page + missing links #1047

Closed

vidvidvid added a commit that referenced this pull request Jan 16, 2022

Revert "Feat/landing (#1018)"

90c317c

This reverts commit 53d9871.

vidvidvid mentioned this pull request Jan 16, 2022

Revert "Feat/landing" #1048

Merged

vidvidvid added a commit that referenced this pull request Jan 16, 2022

Revert "Feat/landing (#1018)" (#1048)

dbd1823

This reverts commit 53d9871.

vercel bot deployed to Preview January 16, 2022 14:22 View deployment

tenfinney pushed a commit that referenced this pull request Mar 1, 2022

Revert "Feat/landing (#1018)" (#1048)

456c71f

This reverts commit 53d9871.

alalonde pushed a commit that referenced this pull request Mar 12, 2022

Revert "Feat/landing (#1018)" (#1048)

d2c137c

This reverts commit 53d9871.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/landing#1018

Feat/landing#1018
vidvidvid merged 60 commits intodevelopfrom
feat/landing

tommymaher15 commented Jan 5, 2022

Uh oh!

vercel bot commented Jan 5, 2022 •

edited

Loading

Uh oh!

vidvidvid commented Jan 14, 2022

Uh oh!

Gnomeski commented Jan 14, 2022 •

edited

Loading

Uh oh!

dan13ram Jan 15, 2022

Uh oh!

dan13ram Jan 15, 2022 •

edited

Loading

Uh oh!

dan13ram Jan 15, 2022

Uh oh!

dan13ram Jan 15, 2022

Uh oh!

dan13ram left a comment

Uh oh!

dan13ram Jan 15, 2022

Uh oh!

tommymaher15 Jan 15, 2022

Uh oh!

peth-yursick commented Jan 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

tommymaher15 commented Jan 5, 2022

Overview

Follow up Improvement Ideas

Implementation

Assets

Uh oh!

vercel bot commented Jan 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vidvidvid commented Jan 14, 2022

Uh oh!

Gnomeski commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dan13ram Jan 15, 2022

Choose a reason for hiding this comment

Uh oh!

dan13ram Jan 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dan13ram Jan 15, 2022

Choose a reason for hiding this comment

Uh oh!

dan13ram Jan 15, 2022

Choose a reason for hiding this comment

Uh oh!

dan13ram left a comment

Choose a reason for hiding this comment

Uh oh!

dan13ram Jan 15, 2022

Choose a reason for hiding this comment

Uh oh!

tommymaher15 Jan 15, 2022

Choose a reason for hiding this comment

Uh oh!

peth-yursick commented Jan 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

vercel bot commented Jan 5, 2022 •

edited

Loading

Gnomeski commented Jan 14, 2022 •

edited

Loading

dan13ram Jan 15, 2022 •

edited

Loading