Retry getting the release PR number on a timeout#96
Merged
Conversation
mcmire
reviewed
Jun 28, 2022
mcmire
left a comment
mcmire
left a comment
Contributor
There was a problem hiding this comment.
Makes sense! A couple of questions.
rekmarks
commented
Jun 28, 2022
rekmarks
commented
Jun 28, 2022
mcmire
approved these changes
Jun 28, 2022
mcmire
left a comment
mcmire
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, this action failed because we failed to get the release PR number via
gh pr view, despite the fact that the PR was created successfully. I hypothesize that this happened because we didn't give GitHub enough time to create the PR and return its number to us. This PR ensures that we retrygh pr viewon a 10-second interval for a total of 60 seconds, to give GitHub enough time to return the result we're looking for.