Skip to content

add exception in the constraints.pro for non MIT license#1888

Merged
kanthesha merged 7 commits intomainfrom
exception-for-non-mit-license
Oct 24, 2023
Merged

add exception in the constraints.pro for non MIT license#1888
kanthesha merged 7 commits intomainfrom
exception-for-non-mit-license

Conversation

@kanthesha
Copy link
Copy Markdown
Contributor

Explanation

In the process of migrating json-rpc-engine to core monorepo, in this PR we are adding the exception in constraints.pro for ISC license.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@kanthesha kanthesha self-assigned this Oct 23, 2023
kanthesha and others added 2 commits October 24, 2023 10:47
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
@kanthesha kanthesha marked this pull request as ready for review October 24, 2023 10:26
@kanthesha kanthesha requested a review from a team as a code owner October 24, 2023 10:26
Copy link
Copy Markdown
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by moving json-rpc-engine into packages/ and running yarn constraints. Works as expected.

@kanthesha kanthesha merged commit 4a93120 into main Oct 24, 2023
@kanthesha kanthesha deleted the exception-for-non-mit-license branch October 24, 2023 19:55
kanthesha added a commit that referenced this pull request Oct 24, 2023
kanthesha added a commit that referenced this pull request Oct 24, 2023
)

Reverts #1888
This PR accidentally removed the below existing constraints. Reverting
the changes.
```
% Non-published packages do not have a license.
gen_enforced_field(WorkspaceCwd, 'license', null) :-
  workspace_field(WorkspaceCwd, 'private', true).
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants