Skip to content

chore: QA NEB-322#41436

Open
Julink-eth wants to merge 1 commit intomainfrom
NEB-322-QA
Open

chore: QA NEB-322#41436
Julink-eth wants to merge 1 commit intomainfrom
NEB-322-QA

Conversation

@Julink-eth
Copy link
Copy Markdown
Contributor

@Julink-eth Julink-eth commented Apr 2, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to https://metamask.github.io/test-dapp-tron/latest/
  2. Connect with your Tron Wallet
  3. Open Metamask in full screen and open the console
  4. Go back to the tron test dapp
  5. Click on "Sign Transaction"
  6. Wait 2 sec in the confirmation screen and click on cancel
  7. Go to the MM console
  8. Wait for 20 sec you should not see an error: "error interface with id ... not found"
  9. Go back to the dapp
  10. Click on "Sign and send transaction" (You should have 1 TRX in your balance)
  11. This time confirm the transaction
  12. Go to the console
  13. Wait for 20 sec you should not see an error: "error interface with id ... not found"

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Switches a wallet-integrated Snap dependency to a preview build, which could change runtime signing/confirmation behavior despite being a small diff. Risk is limited to Tron Snap functionality and dependency resolution.

Overview
Updates dependency resolution to use @metamask-previews/tron-wallet-snap@1.25.0-preview-5a63c56 (via @metamask/tron-wallet-snap) instead of the stable 1.25.0 package, and refreshes yarn.lock accordingly.

Written by Cursor Bugbot for commit 797f202. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-networks PRs from the Networks team label Apr 2, 2026
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​tron-wallet-snap@​1.25.0 ⏵ 1.25.0-preview-5a63c56100 +1100100 +5100 +2100

View full report

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Apr 2, 2026

Builds ready [797f202]
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 1 warn · 🔴 0 fail)

Baseline (latest main): b82d5b2 | Date: 4/24/58221 | Pipeline: 23892091491 | Baseline logs

Interaction Benchmarks
Benchmarkchrome-browserify
loadNewAccount🟢 [Show logs]
confirmTx🟢 [Show logs]
bridgeUserActions🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • bridgeUserActions/bridge_load_page: -14%
  • bridgeUserActions/bridge_search_token: -13%
  • bridgeUserActions/total: -15%
Startup Benchmarks
Benchmarkchrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
startupStandardHome🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]
startupPowerUserHome
🟡 uiStartup
[Show logs]
🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/initialActions: -38%
  • startupPowerUserHome/domInteractive: +11%
  • startupPowerUserHome/backgroundConnect: +41%
  • startupPowerUserHome/numNetworkReqs: +92%
  • startupPowerUserHome/numNetworkReqs: +14%
  • startupStandardHome/initialActions: +67%
  • startupStandardHome/initialActions: -38%
  • startupPowerUserHome/backgroundConnect: +13%
  • startupPowerUserHome/setupStore: -12%
User Journey Benchmarks
Benchmarkchrome-browserify
onboardingImportWallet🟢 [Show logs]
onboardingNewWallet🟢 [Show logs]
assetDetails🟢 [Show logs]
solanaAssetDetails🟢 [Show logs]
importSrpHome🟢 [Show logs]
sendTransactions🟢 [Show logs]
swap🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: +21%
  • onboardingImportWallet/doneButtonToHomeScreen: -74%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: +39%
  • onboardingImportWallet/total: -36%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +15%
  • onboardingNewWallet/doneButtonToAssetList: -32%
  • onboardingNewWallet/total: -26%
  • assetDetails/assetClickToPriceChart: -51%
  • assetDetails/total: -51%
  • solanaAssetDetails/assetClickToPriceChart: -51%
  • solanaAssetDetails/total: -51%
  • importSrpHome/loginToHomeScreen: +13%
  • importSrpHome/openAccountMenuAfterLogin: -53%
  • importSrpHome/homeAfterImportWithNewWallet: -37%
  • importSrpHome/total: -32%
  • swap/openSwapPageFromHome: -82%
  • swap/fetchAndDisplaySwapQuotes: +37%
  • swap/total: +19%
🌐 Dapp Page Load Benchmarks

Current Commit: 797f202 | Date: 4/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±75ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±72ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 87ms (±10ms) 🟢 | historical mean value: 85ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 75ms 1.02s 1.38s 1.30s 1.38s
domContentLoaded 731ms 72ms 692ms 1.03s 974ms 1.03s
firstPaint 87ms 10ms 68ms 168ms 100ms 168ms
firstContentfulPaint 87ms 10ms 68ms 168ms 100ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 114 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-XS team-networks PRs from the Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants