fix: correct speed-up eligibility for pending transactions by vinistevam · Pull Request #41444 · MetaMask/metamask-extension

vinistevam · 2026-04-02T13:17:09Z

Description

CONF-1116 — pending transactions in Activity sometimes showed Queued with no Speed up, even when lower nonces were already confirmed.

On the Activity tab, when several transactions were submitted with low gas, only the first stayed Pending with Speed up and Cancel. Later pending transactions were shown as Queued and Speed up was hidden, even when earlier nonces had already confirmed.

Problem

selectLocalTransactions can include confirmed locally originated transactions (not only pending). useEarliestNonceByChain was taking the minimum nonce over all of those groups. A confirmed entry at a lower nonce kept the “earliest nonce” map stale, so higher pending nonces no longer matched isEarliestNonce, which drives queued vs pending UI and speed-up visibility.

Solution

useEarliestNonceByChain now only considers groups whose primaryTransaction.status is in PENDING_STATUS_HASH (same idea as nonceSortedPendingTransactionsSelector in the legacy transaction list).
ActivityList passes the full localTransactions list unchanged; filtering lives in the hook so the list stays dumb and the hook stays the single place that defines “earliest pending nonce per chain.”

Note on expected vs on-chain behavior
If two transactions are both pending with different nonces (e.g. 395 still in mempool and 396 submitted after), Ethereum processes them in order; only the lowest pending nonce is meaningfully “active” for replacement / speed-up. The bug we fixed is when the UI treated a higher nonce as queued because a non-pending lower nonce was still counted. If product truly wants Speed up on every row regardless of nonce order, that would be a separate product/UX change.

Changelog

CHANGELOG entry: Fixed Activity tab Speed up and pending status using the wrong earliest nonce when completed local transactions were still in the list

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1116

Related discussion: Activity v2 PR review

Manual testing steps

On Sepolia (or Mainnet), send a tx with low gas so it stays pending.
Send another with a higher nonce; confirm the first still pending shows Pending + Speed up; the second may show Queued until the first confirms (expected nonce ordering).
After the first confirms, confirm the next pending shows Pending + Speed up (no stuck Queued from stale nonce 395).
Repeat with a third tx after the second confirms.

Screenshots/Recordings

3x-speed-up-tx.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small, well-tested change to a single UI hook that only adjusts filtering logic for nonce selection; main risk is subtle UI behavior changes if any status mapping is incorrect.

Overview
Fixes earliest-nonce calculation used by Activity speed-up/queued UI by updating useEarliestNonceByChain to only consider transaction groups whose primaryTransaction.status is pending (via PENDING_STATUS_HASH), ignoring confirmed groups that may still be present for display.

Updates and expands useEarliestNonceByChain tests to use a shared buildGroup helper and to cover confirmed-only lists and pending-vs-confirmed mixes (including treating unapproved/approved as pending).

^{Reviewed by Cursor Bugbot for commit 3410401. Bugbot is set up for automated code reviews on this repo. Configure here.}

…yList

github-actions · 2026-04-02T13:17:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…ansactions

…sk/metamask-extension into vs/fix-speed-up-queued-tx

metamaskbotv2 · 2026-04-02T14:36:00Z

Builds ready [be0677d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 3 warn · 🔴 0 fail)

Baseline (latest main): e4d0c5f | Date: 12/5/58221 | Pipeline: 23904284172 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount
🟡 load_new_account
[Show logs]
confirmTx 🟢 [Show logs]
bridgeUserActions 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ loadNewAccount/load_new_account: +50%
↑ loadNewAccount/total: +50%
↑ bridgeUserActions/bridge_load_asset_picker: +14%
↑ bridgeUserActions/bridge_search_token: +17%
↑ bridgeUserActions/total: +18%

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟢 [Show logs] 🟢 [Show logs]
🟡 loadScripts
[Show logs]
🟡 loadScripts
[Show logs]

📈 Results compared to the previous 5 runs on main
↑ startupStandardHome/initialActions: +67%
↓ startupPowerUserHome/domInteractive: -11%
↑ startupPowerUserHome/backgroundConnect: +29%
↓ startupPowerUserHome/numNetworkReqs: -20%
↓ startupStandardHome/domInteractive: -13%
↓ startupPowerUserHome/numNetworkReqs: -18%
↑ startupStandardHome/domInteractive: +13%
↓ startupStandardHome/initialActions: -29%
↓ startupStandardHome/setupStore: -12%
↑ startupPowerUserHome/domInteractive: +13%
↑ startupPowerUserHome/backgroundConnect: +10%
↑ startupPowerUserHome/setupStore: +38%
↑ startupStandardHome/uiStartup: +15%
↑ startupStandardHome/load: +12%
↑ startupStandardHome/domContentLoaded: +12%
↑ startupStandardHome/backgroundConnect: +22%
↑ startupStandardHome/firstReactRender: +12%
↑ startupStandardHome/initialActions: +67%
↑ startupStandardHome/loadScripts: +12%
↑ startupStandardHome/setupStore: +107%
↑ startupStandardHome/numNetworkReqs: +11%
↑ startupPowerUserHome/setupStore: +28%

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟢 [Show logs]
solanaAssetDetails 🟢 [Show logs]
importSrpHome 🟢 [Show logs]
sendTransactions 🟢 [Show logs]
swap 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/metricsToWalletReadyScreen: -35%
↓ onboardingImportWallet/doneButtonToHomeScreen: -75%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +98%
↓ onboardingImportWallet/total: -34%
↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +119%
↓ onboardingNewWallet/doneButtonToAssetList: -27%
↓ onboardingNewWallet/total: -24%
↓ assetDetails/assetClickToPriceChart: -56%
↓ assetDetails/total: -56%
↓ solanaAssetDetails/assetClickToPriceChart: -56%
↓ solanaAssetDetails/total: -56%
↓ importSrpHome/openAccountMenuAfterLogin: -31%
↓ importSrpHome/homeAfterImportWithNewWallet: -44%
↓ importSrpHome/total: -37%
↓ swap/openSwapPageFromHome: -86%
↑ swap/fetchAndDisplaySwapQuotes: +28%

🌐 Dapp Page Load Benchmarks

Current Commit: be0677d | Date: 4/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 732ms (±39ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 86ms (±13ms) 🟢 | historical mean value: 85ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	42ms	1.01s	1.38s	1.07s	1.38s
domContentLoaded	732ms	39ms	703ms	1.03s	752ms	1.03s
firstPaint	86ms	13ms	68ms	204ms	96ms	204ms
firstContentfulPaint	86ms	13ms	68ms	204ms	96ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 162 Bytes (0%)
common: 91 Bytes (0%)

metamaskbotv2 · 2026-04-06T09:12:38Z

Builds ready [12cc96f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24025137393 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -16%
↓ loadNewAccount/total: -16%
↓ bridgeUserActions/bridge_load_asset_picker: -16%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.4s
🟡 confirmTx/FCP: p75 2.4s
🟡 bridgeUserActions/FCP: p75 2.3s

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/load: -12%
↓ startupStandardHome/domContentLoaded: -14%
↑ startupStandardHome/domInteractive: +11%
↑ startupStandardHome/backgroundConnect: +14%
↓ startupStandardHome/firstReactRender: -13%
↑ startupStandardHome/initialActions: +25%
↓ startupStandardHome/loadScripts: -17%
↓ startupPowerUserHome/uiStartup: -11%
↑ startupPowerUserHome/backgroundConnect: +96%
↑ startupPowerUserHome/setupStore: +11%
↓ startupStandardHome/uiStartup: -15%
↓ startupStandardHome/load: -15%
↓ startupStandardHome/domContentLoaded: -14%
↓ startupStandardHome/firstPaint: -14%
↓ startupStandardHome/backgroundConnect: -37%
↓ startupStandardHome/firstReactRender: -24%
↓ startupStandardHome/loadScripts: -14%
↓ startupStandardHome/setupStore: -14%
↓ startupStandardHome/numNetworkReqs: -22%
↓ startupPowerUserHome/domInteractive: -21%
↓ startupPowerUserHome/firstPaint: -16%
↑ startupPowerUserHome/numNetworkReqs: +46%
↓ startupStandardHome/domInteractive: -58%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/numNetworkReqs: -18%
↓ startupPowerUserHome/uiStartup: -11%
↓ startupPowerUserHome/backgroundConnect: -37%
↑ startupPowerUserHome/setupStore: +14%
↓ startupStandardHome/uiStartup: -11%
↓ startupStandardHome/load: -11%
↓ startupStandardHome/domContentLoaded: -10%
↓ startupStandardHome/domInteractive: -40%
↓ startupStandardHome/backgroundConnect: -23%
↓ startupStandardHome/initialActions: -44%
↓ startupStandardHome/loadScripts: -10%
↓ startupStandardHome/setupStore: -63%
↓ startupStandardHome/numNetworkReqs: -13%
↓ startupPowerUserHome/uiStartup: -12%
↓ startupPowerUserHome/backgroundConnect: -24%
↓ startupPowerUserHome/firstReactRender: -11%
↓ startupPowerUserHome/setupStore: -35%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 736ms
🔴 startupPowerUserHome/INP: p75 624ms
🟡 startupPowerUserHome/LCP: p75 3.5s
🟡 startupPowerUserHome/INP: p75 272ms
🟡 startupPowerUserHome/LCP: p75 3.4s

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/metricsToWalletReadyScreen: -18%
↓ onboardingImportWallet/doneButtonToHomeScreen: -73%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +23%
↓ onboardingImportWallet/total: -40%
↑ onboardingNewWallet/srpButtonToPwForm: +16%
↑ onboardingNewWallet/createPwToRecoveryScreen: +14%
↑ onboardingNewWallet/skipBackupToMetricsScreen: +31%
↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +24%
↓ onboardingNewWallet/doneButtonToAssetList: -39%
↓ onboardingNewWallet/total: -30%
↓ assetDetails/assetClickToPriceChart: -47%
↓ assetDetails/total: -47%
↓ solanaAssetDetails/assetClickToPriceChart: -53%
↓ solanaAssetDetails/total: -53%
↓ importSrpHome/openAccountMenuAfterLogin: -72%
↓ importSrpHome/homeAfterImportWithNewWallet: -39%
↓ importSrpHome/total: -33%
↑ sendTransactions/openSendPageFromHome: +98%
↓ sendTransactions/selectTokenToSendFormLoaded: -11%
↑ sendTransactions/reviewTransactionToConfirmationPage: +12%
↑ sendTransactions/total: +13%
↓ swap/openSwapPageFromHome: -85%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/INP: p75 208ms
🟡 assetDetails/FCP: p75 2.4s
🟡 solanaAssetDetails/FCP: p75 2.4s
🟡 importSrpHome/INP: p75 216ms
🟡 importSrpHome/FCP: p75 2.5s
🟡 sendTransactions/FCP: p75 2.5s
🟡 swap/FCP: p75 2.5s

🌐 Dapp Page Load Benchmarks

Current Commit: 12cc96f | Date: 4/6/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 721ms (±36ms) 🟢 | historical mean value: 727ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 86ms (±10ms) 🟢 | historical mean value: 87ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	38ms	998ms	1.32s	1.05s	1.32s
domContentLoaded	721ms	36ms	695ms	998ms	751ms	998ms
firstPaint	86ms	10ms	72ms	168ms	96ms	168ms
firstContentfulPaint	86ms	10ms	72ms	168ms	96ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 162 Bytes (0%)
common: 20 Bytes (0%)

metamaskbotv2 · 2026-04-07T05:28:45Z

Builds ready [da00736]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24065002814 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -18%
↓ loadNewAccount/total: -18%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.6s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/uiStartup: -12%
↓ startupStandardHome/load: -14%
↓ startupStandardHome/domContentLoaded: -16%
↓ startupStandardHome/firstReactRender: -13%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/loadScripts: -19%
↓ startupStandardHome/numNetworkReqs: -21%
↑ startupPowerUserHome/backgroundConnect: +135%
↑ startupPowerUserHome/setupStore: +17%
↓ startupStandardHome/uiStartup: -12%
↓ startupStandardHome/load: -11%
↓ startupStandardHome/firstPaint: -11%
↓ startupStandardHome/backgroundConnect: -30%
↓ startupStandardHome/firstReactRender: -20%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -18%
↑ startupPowerUserHome/numNetworkReqs: +47%
↓ startupStandardHome/domInteractive: -59%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/numNetworkReqs: -18%
↓ startupPowerUserHome/backgroundConnect: -25%
↓ startupStandardHome/uiStartup: -10%
↓ startupStandardHome/domInteractive: -52%
↓ startupStandardHome/backgroundConnect: -17%
↓ startupStandardHome/initialActions: -44%
↓ startupStandardHome/setupStore: -57%
↓ startupStandardHome/numNetworkReqs: -18%
↓ startupPowerUserHome/backgroundConnect: -11%
↓ startupPowerUserHome/setupStore: -33%
↓ startupPowerUserHome/numNetworkReqs: -25%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 792ms
🔴 startupPowerUserHome/INP: p75 568ms
🟡 startupPowerUserHome/LCP: p75 3.5s
🟡 startupPowerUserHome/INP: p75 224ms
🟡 startupPowerUserHome/LCP: p75 3.8s

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/metricsToWalletReadyScreen: -17%
↓ onboardingImportWallet/doneButtonToHomeScreen: -75%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +33%
↓ onboardingImportWallet/total: -38%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -14%
↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +36%
↓ onboardingNewWallet/doneButtonToAssetList: -34%
↓ onboardingNewWallet/total: -28%
↓ assetDetails/assetClickToPriceChart: -60%
↓ assetDetails/total: -60%
↓ solanaAssetDetails/assetClickToPriceChart: -60%
↓ solanaAssetDetails/total: -60%
↓ importSrpHome/openAccountMenuAfterLogin: -69%
↓ importSrpHome/homeAfterImportWithNewWallet: -39%
↓ importSrpHome/total: -34%
↑ sendTransactions/openSendPageFromHome: +94%
↑ sendTransactions/total: +12%
↓ swap/openSwapPageFromHome: -86%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +13%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 2.5s
🟡 solanaAssetDetails/FCP: p75 2.4s
🟡 importSrpHome/INP: p75 248ms
🟡 importSrpHome/FCP: p75 2.4s
🟡 sendTransactions/FCP: p75 2.5s
🟡 swap/FCP: p75 2.5s

🌐 Dapp Page Load Benchmarks

Current Commit: da00736 | Date: 4/7/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±39ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±37ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±10ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	39ms	998ms	1.31s	1.07s	1.31s
domContentLoaded	720ms	37ms	696ms	995ms	759ms	995ms
firstPaint	84ms	10ms	68ms	160ms	96ms	160ms
firstContentfulPaint	84ms	10ms	68ms	160ms	96ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 162 Bytes (0%)
common: 20 Bytes (0%)

metamaskbotv2 · 2026-04-08T05:53:34Z

Builds ready [6c668b8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24119205424 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ bridgeUserActions/bridge_load_asset_picker: -35%
↓ bridgeUserActions/bridge_search_token: -12%
↓ bridgeUserActions/total: -15%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.5s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/uiStartup: -11%
↓ startupStandardHome/load: -13%
↓ startupStandardHome/domContentLoaded: -15%
↑ startupStandardHome/domInteractive: +12%
↓ startupStandardHome/firstPaint: -13%
↑ startupStandardHome/backgroundConnect: +12%
↓ startupStandardHome/firstReactRender: -13%
↑ startupStandardHome/initialActions: +25%
↓ startupStandardHome/loadScripts: -17%
↓ startupStandardHome/numNetworkReqs: -21%
↓ startupPowerUserHome/domInteractive: -12%
↑ startupPowerUserHome/backgroundConnect: +106%
↑ startupPowerUserHome/setupStore: +11%
↓ startupPowerUserHome/numNetworkReqs: -11%
↓ startupStandardHome/uiStartup: -16%
↓ startupStandardHome/load: -16%
↓ startupStandardHome/domContentLoaded: -15%
↓ startupStandardHome/backgroundConnect: -38%
↓ startupStandardHome/firstReactRender: -24%
↓ startupStandardHome/loadScripts: -15%
↓ startupStandardHome/setupStore: -14%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -13%
↓ startupPowerUserHome/numNetworkReqs: -35%
↓ startupStandardHome/domInteractive: -60%
↓ startupStandardHome/initialActions: -38%
↑ startupStandardHome/setupStore: +14%
↓ startupStandardHome/numNetworkReqs: -18%
↓ startupPowerUserHome/backgroundConnect: -20%
↑ startupPowerUserHome/setupStore: +39%
↓ startupStandardHome/domInteractive: -39%
↓ startupStandardHome/backgroundConnect: -14%
↓ startupStandardHome/initialActions: -44%
↓ startupStandardHome/setupStore: -54%
↓ startupStandardHome/numNetworkReqs: -11%
↓ startupPowerUserHome/backgroundConnect: -23%
↑ startupPowerUserHome/setupStore: +20%
↓ startupPowerUserHome/numNetworkReqs: -14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 632ms
🔴 startupPowerUserHome/INP: p75 640ms
🟡 startupPowerUserHome/LCP: p75 3.6s
🟡 startupPowerUserHome/LCP: p75 3.6s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -85%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -34%
↓ onboardingImportWallet/doneButtonToHomeScreen: -77%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +32%
↓ onboardingImportWallet/total: -41%
↓ onboardingNewWallet/srpButtonToPwForm: -78%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -67%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -28%
↓ onboardingNewWallet/doneButtonToAssetList: -29%
↓ onboardingNewWallet/total: -29%
↓ assetDetails/assetClickToPriceChart: -43%
↓ assetDetails/total: -43%
↓ solanaAssetDetails/assetClickToPriceChart: -72%
↓ solanaAssetDetails/total: -72%
↓ importSrpHome/openAccountMenuAfterLogin: -76%
↓ importSrpHome/homeAfterImportWithNewWallet: -70%
↓ importSrpHome/total: -60%
↓ sendTransactions/openSendPageFromHome: -13%
↓ sendTransactions/selectTokenToSendFormLoaded: -31%
↑ sendTransactions/reviewTransactionToConfirmationPage: +34%
↑ sendTransactions/total: +31%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/INP: p75 224ms
🟡 assetDetails/FCP: p75 2.6s
🟡 solanaAssetDetails/FCP: p75 2.5s
🟡 importSrpHome/FCP: p75 2.4s
🟡 sendTransactions/INP: p75 224ms
🟡 sendTransactions/FCP: p75 2.4s
🟡 swap/FCP: p75 2.5s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs

background: 58 Bytes (0%)
ui: 162 Bytes (0%)
common: 20 Bytes (0%)

sonarqubecloud · 2026-04-08T09:37:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-04-08T10:00:12Z

Builds ready [3410401]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24128084240 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ bridgeUserActions/bridge_load_asset_picker: -25%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.6s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome
🟡 uiStartup
[Show logs]
🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/load: -12%
↓ startupStandardHome/domContentLoaded: -14%
↑ startupStandardHome/domInteractive: +12%
↑ startupStandardHome/backgroundConnect: +13%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/loadScripts: -17%
↑ startupStandardHome/setupStore: +14%
↓ startupStandardHome/numNetworkReqs: -21%
↓ startupPowerUserHome/domInteractive: -10%
↑ startupPowerUserHome/backgroundConnect: +158%
↑ startupPowerUserHome/setupStore: +17%
↑ startupPowerUserHome/numNetworkReqs: +23%
↓ startupStandardHome/load: -12%
↓ startupStandardHome/domContentLoaded: -12%
↓ startupStandardHome/firstPaint: -18%
↓ startupStandardHome/backgroundConnect: -32%
↓ startupStandardHome/firstReactRender: -20%
↓ startupStandardHome/loadScripts: -11%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -22%
↓ startupPowerUserHome/firstPaint: -11%
↑ startupPowerUserHome/numNetworkReqs: +45%
↓ startupStandardHome/domInteractive: -59%
↓ startupStandardHome/initialActions: -38%
↑ startupStandardHome/setupStore: +14%
↓ startupStandardHome/numNetworkReqs: -18%
↓ startupPowerUserHome/domInteractive: -18%
↓ startupPowerUserHome/backgroundConnect: -34%
↓ startupStandardHome/domInteractive: -30%
↓ startupStandardHome/backgroundConnect: -23%
↓ startupStandardHome/initialActions: -44%
↓ startupStandardHome/setupStore: -63%
↓ startupStandardHome/numNetworkReqs: -11%
↓ startupPowerUserHome/uiStartup: -12%
↓ startupPowerUserHome/domInteractive: -14%
↓ startupPowerUserHome/backgroundConnect: -33%
↓ startupPowerUserHome/setupStore: -37%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 808ms
🔴 startupPowerUserHome/INP: p75 752ms
🟡 startupPowerUserHome/LCP: p75 3.6s
🟡 startupPowerUserHome/LCP: p75 3.4s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -84%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -29%
↓ onboardingImportWallet/doneButtonToHomeScreen: -74%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +24%
↓ onboardingImportWallet/total: -42%
↓ onboardingNewWallet/srpButtonToPwForm: -77%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -69%
↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +24%
↓ onboardingNewWallet/doneButtonToAssetList: -45%
↓ onboardingNewWallet/total: -41%
↓ assetDetails/assetClickToPriceChart: -48%
↓ assetDetails/total: -48%
↓ solanaAssetDetails/assetClickToPriceChart: -74%
↓ solanaAssetDetails/total: -74%
↓ importSrpHome/openAccountMenuAfterLogin: -74%
↓ importSrpHome/homeAfterImportWithNewWallet: -70%
↓ importSrpHome/total: -61%
↓ sendTransactions/openSendPageFromHome: -21%
↓ sendTransactions/selectTokenToSendFormLoaded: -25%
↑ sendTransactions/reviewTransactionToConfirmationPage: +36%
↑ sendTransactions/total: +33%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 2.3s
🟡 solanaAssetDetails/FCP: p75 2.4s
🟡 importSrpHome/FCP: p75 2.5s
🟡 sendTransactions/INP: p75 224ms
🟡 sendTransactions/FCP: p75 2.4s
🟡 swap/FCP: p75 2.4s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs

background: 58 Bytes (0%)
ui: 162 Bytes (0%)
common: 20 Bytes (0%)

refactor: optimize nonce tracking for pending transactions in Activit…

19a2d7b

…yList

vinistevam added the team-confirmations Push issues to confirmations team label Apr 2, 2026

vinistevam temporarily deployed to pr-comment April 2, 2026 13:17 — with GitHub Actions Inactive

github-actions bot added the size-S label Apr 2, 2026

Merge branch 'main' into vs/fix-speed-up-queued-tx

51ca001

vinistevam temporarily deployed to pr-comment April 2, 2026 13:37 — with GitHub Actions Inactive

vinistevam marked this pull request as ready for review April 2, 2026 13:39

vinistevam requested a review from a team as a code owner April 2, 2026 13:39

vinistevam temporarily deployed to pr-comment April 2, 2026 13:39 — with GitHub Actions Inactive

vinistevam added 2 commits April 2, 2026 14:58

refactor: streamline nonce calculation by considering only pending tr…

cd57a78

…ansactions

Merge branch 'vs/fix-speed-up-queued-tx' of https://github.com/MetaMa…

be0677d

…sk/metamask-extension into vs/fix-speed-up-queued-tx

vinistevam had a problem deploying to pr-comment April 2, 2026 14:01 — with GitHub Actions Failure

github-actions bot added size-M and removed size-S labels Apr 2, 2026

vinistevam temporarily deployed to pr-comment April 2, 2026 14:31 — with GitHub Actions Inactive

vinistevam removed the request for review from a team April 6, 2026 08:38

Merge branch 'main' into vs/fix-speed-up-queued-tx

12cc96f

vinistevam temporarily deployed to pr-comment April 6, 2026 08:38 — with GitHub Actions Inactive

exalate-issue-sync bot mentioned this pull request Apr 6, 2026

[Bug]: Speed-up button only displayed for the first transaction #41351

Closed

vinistevam temporarily deployed to pr-comment April 6, 2026 09:08 — with GitHub Actions Inactive

Merge branch 'main' into vs/fix-speed-up-queued-tx

da00736

vinistevam temporarily deployed to pr-comment April 7, 2026 04:54 — with GitHub Actions Inactive

vinistevam temporarily deployed to pr-comment April 7, 2026 05:24 — with GitHub Actions Inactive

jpuri approved these changes Apr 7, 2026

View reviewed changes

pedronfigueiredo approved these changes Apr 7, 2026

View reviewed changes

vinistevam added this pull request to the merge queue Apr 8, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2026

Merge branch 'main' into vs/fix-speed-up-queued-tx

6c668b8

vinistevam temporarily deployed to pr-comment April 8, 2026 05:19 — with GitHub Actions Inactive

vinistevam enabled auto-merge April 8, 2026 05:19

vinistevam temporarily deployed to pr-comment April 8, 2026 05:48 — with GitHub Actions Inactive

Merge branch 'main' into vs/fix-speed-up-queued-tx

3410401

vinistevam temporarily deployed to pr-comment April 8, 2026 09:24 — with GitHub Actions Inactive

vinistevam temporarily deployed to pr-comment April 8, 2026 09:55 — with GitHub Actions Inactive

vinistevam added this pull request to the merge queue Apr 8, 2026

Merged via the queue into main with commit 4c20c28 Apr 8, 2026
398 of 402 checks passed

vinistevam deleted the vs/fix-speed-up-queued-tx branch April 8, 2026 11:11

github-actions bot locked and limited conversation to collaborators Apr 8, 2026

metamaskbot added the release-13.27.0 Issue or pull request that will be included in release 13.27.0 label Apr 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: correct speed-up eligibility for pending transactions#41444

fix: correct speed-up eligibility for pending transactions#41444
vinistevam merged 8 commits intomainfrom
vs/fix-speed-up-queued-tx

vinistevam commented Apr 2, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

metamaskbotv2 bot commented Apr 2, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Apr 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Apr 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

sonarqubecloud bot commented Apr 8, 2026

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vinistevam commented Apr 2, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Solution

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

metamaskbotv2 bot commented Apr 2, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Apr 6, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Apr 7, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

sonarqubecloud bot commented Apr 8, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vinistevam commented Apr 2, 2026 •

edited by cursor bot

Loading