Skip to content

chore: [DSYS-616] replace single BannerBase instance and update @deprecated JSDoc#41447

Draft
cursor[bot] wants to merge 1 commit intomainfrom
cursor/component-instance-jsdoc-2dbe
Draft

chore: [DSYS-616] replace single BannerBase instance and update @deprecated JSDoc#41447
cursor[bot] wants to merge 1 commit intomainfrom
cursor/component-instance-jsdoc-2dbe

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor bot commented Apr 2, 2026

Description

Processes the latest DSYS-616 BannerBase migration docs and applies one safe extension migration step.

Changes made:

  • Updated legacy BannerBase @deprecated JSDoc to include the migration guide link.
  • Replaced exactly one production usage of legacy BannerBase with MMDS BannerBase in the network connection banner.
  • Updated that callsite to use class-based rounding (rounded-md) instead of legacy borderRadius prop, per migration guidance to prefer explicit MMDS APIs and styling classes.

DSYS_EPIC: DSYS-616
Processed MIGRATION_DOCS_VERSION: 79f71d38

Changelog

CHANGELOG entry: null

Related issues

Fixes: DSYS-632

Manual testing steps

  1. Navigate to a state where NetworkConnectionBanner is rendered (degraded/unavailable network connection).
  2. Verify banner content still renders with icon, primary text, and secondary action text.
  3. Verify no React unknown-prop warnings are emitted for borderRadius from this banner path.
  4. Confirm legacy BannerBase includes migration-link @deprecated JSDoc.

Migration doc discrepancies found

None.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Open in Web View Automation 

…docs

Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
@cursor cursor bot temporarily deployed to pr-comment April 2, 2026 14:13 Inactive
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Apr 2, 2026

✨ Files requiring CODEOWNER review ✨

🎨 @MetaMask/design-system-engineers (1 files, +3 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 component-library/
        • 📁 banner-base/
          • 📄 banner-base.tsx +3 -0

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@cursor cursor bot temporarily deployed to pr-comment April 2, 2026 14:41 Inactive
@metamaskbotv2
Copy link
Copy Markdown
Contributor

metamaskbotv2 bot commented Apr 2, 2026

Builds ready [066e874]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)

Baseline (latest main): e4d0c5f | Date: 12/5/58221 | Pipeline: 23904801607 | Baseline logs

Interaction Benchmarks
Benchmarkchrome-browserify
loadNewAccount🟢 [Show logs]
confirmTx🟢 [Show logs]
bridgeUserActions🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • bridgeUserActions/bridge_load_asset_picker: +17%
Startup Benchmarks
Benchmarkchrome-browserifychrome-webpackfirefox-browserifyfirefox-webpack
startupStandardHome🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]
startupPowerUserHome🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/initialActions: -17%
  • startupStandardHome/setupStore: +13%
  • startupPowerUserHome/uiStartup: +13%
  • startupPowerUserHome/domInteractive: -17%
  • startupPowerUserHome/firstPaint: +15%
  • startupPowerUserHome/backgroundConnect: +12%
  • startupPowerUserHome/numNetworkReqs: -18%
  • startupStandardHome/domInteractive: +17%
  • startupStandardHome/initialActions: -29%
  • startupStandardHome/setupStore: -12%
  • startupPowerUserHome/backgroundConnect: +13%
  • startupPowerUserHome/setupStore: +25%
  • startupStandardHome/domInteractive: -11%
  • startupStandardHome/initialActions: +67%
  • startupStandardHome/setupStore: +77%
  • startupPowerUserHome/domInteractive: +14%
  • startupPowerUserHome/numNetworkReqs: -40%
User Journey Benchmarks
Benchmarkchrome-browserify
onboardingImportWallet🟢 [Show logs]
onboardingNewWallet🟢 [Show logs]
assetDetails🟢 [Show logs]
solanaAssetDetails🟢 [Show logs]
importSrpHome🟢 [Show logs]
sendTransactions🟢 [Show logs]
swap🟢 [Show logs]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: -20%
  • onboardingImportWallet/doneButtonToHomeScreen: -77%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: +98%
  • onboardingImportWallet/total: -33%
  • onboardingNewWallet/skipBackupToMetricsScreen: +15%
  • onboardingNewWallet/doneButtonToAssetList: -43%
  • onboardingNewWallet/total: -36%
  • assetDetails/assetClickToPriceChart: -46%
  • assetDetails/total: -46%
  • solanaAssetDetails/assetClickToPriceChart: -40%
  • solanaAssetDetails/total: -40%
  • importSrpHome/openAccountMenuAfterLogin: -19%
  • importSrpHome/homeAfterImportWithNewWallet: -45%
  • importSrpHome/total: -39%
  • swap/openSwapPageFromHome: -87%
  • swap/fetchAndDisplaySwapQuotes: +28%
🌐 Dapp Page Load Benchmarks

Current Commit: 066e874 | Date: 4/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.01s (±36ms) 🟡
  • domContentLoaded-> current mean value: 711ms (±34ms) 🟢
  • firstContentfulPaint-> current mean value: 83ms (±10ms) 🟢

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.01s 36ms 988ms 1.29s 1.03s 1.29s
domContentLoaded 711ms 34ms 686ms 974ms 724ms 974ms
firstPaint 83ms 10ms 68ms 160ms 92ms 160ms
firstContentfulPaint 83ms 10ms 68ms 160ms 92ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 59 Bytes (0%)
  • common: 20 Bytes (0%)

@georgewrmarshall georgewrmarshall self-assigned this Apr 8, 2026
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-XS team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants