chore: [DSYS-616] replace single BannerBase instance and update @deprecated JSDoc#41447
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
chore: [DSYS-616] replace single BannerBase instance and update @deprecated JSDoc#41447cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
…docs Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Contributor
✨ Files requiring CODEOWNER review ✨🎨 @MetaMask/design-system-engineers (1 files, +3 -0)
|
|
Contributor
Builds ready [066e874]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Processes the latest DSYS-616 BannerBase migration docs and applies one safe extension migration step.
Changes made:
BannerBase@deprecatedJSDoc to include the migration guide link.BannerBasewith MMDSBannerBasein the network connection banner.rounded-md) instead of legacyborderRadiusprop, per migration guidance to prefer explicit MMDS APIs and styling classes.DSYS_EPIC: DSYS-616
Processed MIGRATION_DOCS_VERSION: 79f71d38
Changelog
CHANGELOG entry: null
Related issues
Fixes: DSYS-632
Manual testing steps
NetworkConnectionBanneris rendered (degraded/unavailable network connection).borderRadiusfrom this banner path.BannerBaseincludes migration-link@deprecatedJSDoc.Migration doc discrepancies found
None.
Pre-merge author checklist
Pre-merge reviewer checklist