Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
davibroc
added
the
no-changelog
Contributor
✨ Files requiring CODEOWNER review ✨🕵️ @MetaMask/extension-privacy-reviewers (1 files, +1 -0)
🧪 @MetaMask/qa (1 files, +36 -0)
🔄 @MetaMask/swaps-engineers (7 files, +660 -107)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Contributor
Builds ready [71711e5]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
davibroc
force-pushed
the
test/enable-stx-bridge-tests
branch
from
fc07445 to
72a0784
Compare
Contributor
Builds ready [72a0784]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 12 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Changes are limited to E2E test fixtures/mocks and a privacy allowlist entry, with no production logic impact; main risk is increased test flakiness due to new async SSE/STX flows and timeouts.
Overview
Updates Bridge E2E coverage to run with SSE quote streaming enabled and (optionally) Smart Transactions (STX), including new mocks for
getQuoteStreamand STX sentinel/transaction service endpoints and updated fixture flag plumbing.Adjusts bridge test flows to handle the STX status modal (waiting for complete/failed and closing to view activity), refactors shared
enterBridgeQuotehelper, and tweaks a few test expectations/mock payloads (e.g., balances, tx status shape, and swap quotevalue). Also addstx-sentinel-linea-mainnet.api.cx.metamask.iotoprivacy-snapshot.json.Written by Cursor Bugbot for commit 72a0784. This will update automatically on new commits. Configure here.