Fix single-line GitHub API response parsing#8013
Conversation
|
@StephanStS This issue is not dedicated to Kuma. It's a general issue with fetching correct version string via GitHub API #8009 |
There was a problem hiding this comment.
Pull request overview
This PR fixes Uptime Kuma version detection in dietpi-software so the installer pulls the actual latest GitHub release instead of consistently falling back to an older hardcoded version.
Changes:
- Update GitHub API
tag_nameparsing for Uptime Kuma latest release detection. - Add a CHANGELOG entry documenting the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dietpi/dietpi-software | Adjusts Uptime Kuma version detection logic when downloading the release tarball. |
| CHANGELOG.txt | Documents the Uptime Kuma installer version-detection fix. |
You can also share your feedback on Copilot code review. Take the survey.
|
Theoretically there is another option like |
Works. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@StephanStS Fallback version will be automatically updated by GitHub Actions on an own PR #7976 |
Does this require an own change at a different place / within any bot (regarding the determination of newer versions)? |
|
@MichaIng create a bot who is checking these fallback URL automatically. https://github.com/MichaIng/DietPi/actions/workflows/update_urls.yml |
|
The |
Then, this task was not successful, because there is a newer Uptime Kuma since last week (https://github.com/louislam/uptime-kuma/releases). |
I guess a misunderstanding, the PR is open and has not been merged into DEV branch yet. It will be done short before BETA testing. The GitHub agent already fetched the new version. see the linked PR above |
Aaah, the last entry. I missed that, my fault. :-) |
|
Great, this works as well on @copilot In
|
…s for arch-specific checks (#8016) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MichaIng <micha@dietpi.com>
Co-Authored-By: Copilot <175728472+Copilot@users.noreply.github.com> Co-Authored-By: MichaIng <micha@dietpi.com> Co-Authored-By: Copilot <198982749+Copilot@users.noreply.github.com>
ChatGPT also gave this optional solution:
Did not test this, maybe halluzination. :-)