Skip to content

Remove Salesforce import planning documents, add a demo video, and up…#665

Merged
ashwin31 merged 1 commit intomasterfrom
sf_import
Mar 1, 2026
Merged

Remove Salesforce import planning documents, add a demo video, and up…#665
ashwin31 merged 1 commit intomasterfrom
sf_import

Conversation

@ashwin31
Copy link
Member

@ashwin31 ashwin31 commented Mar 1, 2026

…date the README.

Summary by CodeRabbit

  • Documentation
    • Fixed demo video link in README to point to the correct file location, ensuring users can access the demo video properly.
    • Removed archived planning documentation related to Salesforce integration features.

Copilot AI review requested due to automatic review settings March 1, 2026 07:57
@ashwin31 ashwin31 merged commit 1d4d3dd into master Mar 1, 2026
5 checks passed
@ashwin31 ashwin31 deleted the sf_import branch March 1, 2026 07:57
@coderabbitai
Copy link

coderabbitai bot commented Mar 1, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6a2960 and 6fbe836.

⛔ Files ignored due to path filters (1)
  • docs/assets/demo.webm is excluded by !**/*.webm
📒 Files selected for processing (3)
  • README.md
  • docs/plans/2026-02-18-salesforce-import-design.md
  • docs/plans/2026-02-18-salesforce-import-plan.md

📝 Walkthrough

Walkthrough

Documentation and configuration updates: demo video path corrected in README.md and Salesforce import design and plan documentation files removed from the repository.

Changes

Cohort / File(s) Summary
Documentation Removal
docs/plans/2026-02-18-salesforce-import-design.md, docs/plans/2026-02-18-salesforce-import-plan.md
Salesforce import feature design and implementation plan documents deleted (2,330 lines removed).
Configuration Update
README.md
Demo video asset path updated from docs/media/demo.webm to docs/assets/demo.webm.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Sf import #654: Originally introduced the Salesforce import design and plan documentation that this PR removes.

Poem

🐰 Plans and designs take flight,
Old paths fade to morning light,
Assets shuffle, links now right,
Rabbit cleans the digital sight! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sf_import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes previously committed Salesforce import planning/design documents and updates the README to point to the current location of the demo video asset.

Changes:

  • Deleted Salesforce import plan and design markdown docs under docs/plans/.
  • Updated the README demo video link to reference docs/assets/demo.webm.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
docs/plans/2026-02-18-salesforce-import-plan.md Removed Salesforce import implementation planning document.
docs/plans/2026-02-18-salesforce-import-design.md Removed Salesforce import feature design document.
README.md Updated demo video link path to docs/assets/demo.webm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

![Coverage](./coverage-badge.svg)

<https://github.com/MicroPyramid/Django-CRM/raw/master/docs/media/demo.webm>
<https://github.com/MicroPyramid/Django-CRM/raw/master/docs/assets/demo.webm>
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo link still hardcodes the master branch in the raw GitHub URL. Since this PR is targeting main, this URL will 404 if the repo no longer has a master branch. Consider switching the link to raw/main/... (or using a relative link to the file in the repo) so it stays valid.

Suggested change
<https://github.com/MicroPyramid/Django-CRM/raw/master/docs/assets/demo.webm>
<https://github.com/MicroPyramid/Django-CRM/raw/main/docs/assets/demo.webm>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants