Enabling async functions by default#1691
Conversation
| }); | ||
| } | ||
| }, | ||
| { |
There was a problem hiding this comment.
This is the new test case added
|
Can we also move async debugger tests from full to core, that will make sure async functionality is working as expected in ChakraCore/JsRT debugging as well. |
aneeshdk
force-pushed
the
EnableAsyncFunc
branch
from
d8cb4fe to
96aa219
Compare
|
Moved the debugger test cases |
| "sourceText": "return await af1(10)", | ||
| "function": "af2" | ||
| }, | ||
| { |
There was a problem hiding this comment.
In PDM based debugger baselines I see a frame here "Generator.prototype.next" why is it not here?
There was a problem hiding this comment.
Ok, it seems PDM enables library stack frames and our default value is false so ChakraCore doesn't give it. For now its fine but we may need to expose a functionality to enable this in ChakraCore in future.
There was a problem hiding this comment.
| { | ||
| "line": 28, | ||
| "column": 0, | ||
| "sourceText": "p.then(result => {\r\n if (result === 100) {\r\n print(\"PASS\");\r\n }\r\n },\r\n error => {\r\n print(\"Failed : \" + error);\r\n } \r\n)", |
There was a problem hiding this comment.
curious why it is not truncated. Did we change the default, or ch has different default?
There was a problem hiding this comment.
sourceText is not truncated, same as PDM (callstack text) baseline behavior.
| <default> | ||
| <files>default.js</files> | ||
| <compile-flags>-force:deferparse -ES6DefaultArgs -ES7AsyncAwait -ES6Generators -args summary -endargs</compile-flags> | ||
| <compile-flags>-force:deferparse -ES6DefaultArgs -ES6Generators -args summary -endargs</compile-flags> |
There was a problem hiding this comment.
nit: while you are here , why don't you remove other flags for this test?
|
|
Enabling async functions by default. Also added one new test case to verify the arguments.callee behavior.
aneeshdk
force-pushed
the
EnableAsyncFunc
branch
from
96aa219 to
fd0e438
Compare
|
@dotnet-bot test ubuntu_linux_test please |
|
@dotnet-bot test Ubuntu ubuntu_linux_test please |
5 participants
Enabling async functions by default. Also added one new test case to
verify the arguments.callee behavior.