This repository was archived by the owner on Jun 17, 2024. It is now read-only.
Bump scikit-learn, then train and pickle models.#32
Open
richardkmichael wants to merge 3 commits intoMicrosoftResearch:masterfrom
Open
Bump scikit-learn, then train and pickle models.#32richardkmichael wants to merge 3 commits intoMicrosoftResearch:masterfrom
richardkmichael wants to merge 3 commits intoMicrosoftResearch:masterfrom
Conversation
Changes to numpy and pandas since this code was originally written cause a `ValueError`, breaking an `assert` in the model comparison code. Appears due to numpy beginning to delegate to pandas for `.any()` (and other functions), which itself returns a Series instead of single boolean, resulting in error "Truth value of a Series is ambiguous". Pin numpy and pandas at the versions which work. Also add missing xlrd dependency, required during model training. Create `requirements.txt` for pip to give absolute dependency clarity and simplify installation.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, this is on top of #31 .
Bump scikit-learn to 0.18.1 (#13 also does this), then train and pickle models.
This helps working with related Elevation, so there is no scikit-learn compatibility and models can be unpickled (by calling code in Elevation).
(Also removes unnecessary execute permissions from the pickle files.)