Skip to content

ALFMOB-202: Fix iOS 26 liquid glass effect bug#54

Open
paulcristian-mindera wants to merge 20 commits intomainfrom
bug/ALFMOB-202-fix-ios26-tabbar-issue
Open

ALFMOB-202: Fix iOS 26 liquid glass effect bug#54
paulcristian-mindera wants to merge 20 commits intomainfrom
bug/ALFMOB-202-fix-ios26-tabbar-issue

Conversation

@paulcristian-mindera
Copy link
Copy Markdown
Contributor

@paulcristian-mindera paulcristian-mindera commented Dec 18, 2025

With Glass on Tab Bar Without Glass
simulator_screenshot_500BEDC4-B044-49D9-9430-D96DEBA2D189 simulator_screenshot_BFDE279C-F5FC-4E29-BDDB-F0977AB92318

Copy link
Copy Markdown
Contributor

@amccall-mindera amccall-mindera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and good to go

@amccall-mindera amccall-mindera force-pushed the bug/ALFMOB-202-fix-ios26-tabbar-issue branch from 5cebc6b to 20b12b1 Compare December 23, 2025 13:03
Alfie.xctestplan,
"Configuration/Debug/GoogleService-Info.plist",
"Configuration/Debug/GoogleService-Info.plist.secret",
"Configuration/Release/GoogleService-Info.plist",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this deliberate?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not remember deleting the reference but I thought I added it not removed it

@amccall-mindera
Copy link
Copy Markdown
Contributor

Code Review — ALFMOB-202: iOS 26 TabBar Fix

🟡 High — .toolbar(.hidden, for: .tabBar) modifier placement

The .toolbar(.hidden, for: .tabBar) modifier appears to be applied to the ForEach inside the TabView rather than the TabView itself in RootTabView.swift.

Current:

TabView(selection: $viewModel.selectedTab) {
    ForEach(viewModel.tabs, id: \.self) { tab in
        // ...
    }
    .toolbar(.hidden, for: .tabBar)  // Applied to ForEach
}

Suggested:

TabView(selection: $viewModel.selectedTab) {
    ForEach(viewModel.tabs, id: \.self) { tab in
        // ...
    }
}
.toolbar(.hidden, for: .tabBar)  // Applied to TabView

This may not reliably hide the system tab bar across all iOS versions (16.0+), potentially causing the liquid glass effect to still appear on some devices. Could you verify this works correctly on both iOS 16 and iOS 26 simulators?

Overall approach is sound — hiding the system tab bar and using a custom one is the right call for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants