Do not follow symlinks when looking for the stdlib files.#956
Open
vitor1001 wants to merge 1 commit intoMiniZinc:developfrom
Open
Do not follow symlinks when looking for the stdlib files.#956vitor1001 wants to merge 1 commit intoMiniZinc:developfrom
vitor1001 wants to merge 1 commit intoMiniZinc:developfrom
Conversation
This aligns MiniZinc with the standard behavior of *nix binaries that when a tool expects some directory hierarchy, that must match the reality before following any eventual symlinks, not after. In particular, the Bazel build system uses a lot of symlinks, making the behavior before this CL particularly confusing.
Member
|
We're considering the switch to C++17, which would enable the use of |
Contributor
Author
|
Hi Guido! Yes, a much simpler implementation using std::string file_path(const std::string& filename, const std::string& basePath) {
std::filesystem::path path(filename);
if (!basePath.empty() && !path.is_absolute()) {
path = std::filesystem::path(basePath) / path;
}
if (!path.is_absolute()) {
path = std::filesystem::current_path() / path;
}
return path.lexically_normal();
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns MiniZinc with the standard behavior of *nix binaries that when a tool expects some directory hierarchy, that must match the reality before following any eventual symlinks, not after.
In particular, the Bazel build system uses a lot of symlinks, making the behavior before this CL particularly confusing.