Don't suggest nodes which the source does not have requirements for#157
Open
willkroboth wants to merge 1 commit intoMojang:masterfrom
Open
Don't suggest nodes which the source does not have requirements for#157willkroboth wants to merge 1 commit intoMojang:masterfrom
willkroboth wants to merge 1 commit intoMojang:masterfrom
Conversation
|
Look good to me. This pull-request works perfect. Currently, the results of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, requirements are not checked when generating suggestions. This means that the following test fails:
Since the
invalidliteral was given the requiremento -> false, the source cannot execute that node or any of its children. However,invalidis still given as a suggestion. Since the source is not allowed to use this node, it should not have it suggested, since that confusingly suggests it could work.This PR fixes this issue by ignoring a node's suggestions if the source does not meet its requirements.