Retrofitting: Individual Tests :- 31 Tests Parameterised#1
Open
monilnarang1 wants to merge 2 commits intoreleaseBranch-3.3.1from
Open
Retrofitting: Individual Tests :- 31 Tests Parameterised#1monilnarang1 wants to merge 2 commits intoreleaseBranch-3.3.1from
monilnarang1 wants to merge 2 commits intoreleaseBranch-3.3.1from
Conversation
monilnarang1
changed the title
monilnarang1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has:-
31 Unit tests retrofitted, selected individually via assert equal statements
Test Parameterised :- 30 (PUTs #)
Bugs found :- 4 (Potential Bug #)
New Test Added :- 1 (CUTs #)
Classes Covered :- 9
Old tests which can be removed after parameterisation :- 2 (Can be removed #) -> We can find / modify tests to make more of these if we are interested, I wasn't deliberately looking for them and still found 2.
In many places, I have created two new classes inside the test class, using
@RunWith(Enclosed.class)to segregate parameterized and non-parameterized tests. If we use@RunWith(Parameterized.class)directly in a class, then all the tests, even the non-parameterized ones, would run multiple times.This approach worked fine, but in some places, it required changing the ordering of tests; please bare with such scenarios until I try to find a way out. Also, indentation is deliberately not appropriately done for such cases to make the PR easy to perceive. Once I get the green flag will update it.