Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository from pre-commit to prek for git hooks, enabling workspace-aware hook management. The migration splits hooks by workspace project so that only modified projects run their respective formatting and checking commands.
Key changes:
- Added
install-prektarget to Makefile that installs prek and sets up git hooks - Created workspace-specific pre-commit configs for kosong and kaos packages with orphan mode
- Updated root pre-commit config to use project-specific make targets (format-kimi-cli, check-kimi-cli)
- Updated CONTRIBUTING.md documentation to reflect prek usage and workspace mode behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Added install-prek target and integrated it into prepare target to automatically install prek and hooks during setup |
| .pre-commit-config.yaml | Updated hook IDs and names to use project-specific targets (format-kimi-cli, check-kimi-cli) for the root workspace |
| packages/kosong/.pre-commit-config.yaml | Added orphan config for kosong package with hooks that run format-kosong and check-kosong from repo root |
| packages/kaos/.pre-commit-config.yaml | Added orphan config for kaos package with hooks that run format-pykaos and check-pykaos from repo root |
| CONTRIBUTING.md | Updated documentation from pre-commit to prek, explaining workspace mode and new installation process |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing