Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🦋 Changeset detectedLatest commit: db0dd39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d40d8c4094
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 193d6cd299
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
❌ Nix build failed |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db0dd39f42
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export type FeedbackReason = z.infer<typeof feedbackReasonsSchema>['reasons'][number]; | ||
|
|
||
| export async function loadFeedbackReasons(): Promise<readonly FeedbackReason[] | undefined> { | ||
| const config = await getKimiWebApi().getClientConfig(FEEDBACK_REASONS_CONFIG).catch(() => undefined); |
There was a problem hiding this comment.
Fetch reason choices from the reply's owning host
For an SSH reply whose host has a different region or KIMI_CODE_BASE_URL, this call still uses the aggregate API's locally routed getClientConfig, while createFeedback and updateFeedback are routed to the session owner. The popover therefore displays and submits the local daemon's reason IDs to feedback issued by the remote daemon. Load this configuration through the session's owning device API, as is already done for the rating itself.
Useful? React with 👍 / 👎.
| void loadFeedbackReasons().then(reasons => { | ||
| if (!selected.value.length) configuredReasons.value = reasons; | ||
| }); |
There was a problem hiding this comment.
Resolve configured reasons before accepting fallback choices
When the cloud configuration is still loading, the popover immediately exposes the built-in reasons; if the user selects one before this promise resolves, the selected guard discards the fetched configuration and submits an ID that may not exist in the configured reason set. This silently defeats a dynamically configured feedback experiment for fast users or slow connections, so either wait for the fetch before enabling choices or reconcile selections with the resolved configuration.
Useful? React with 👍 / 👎.
| export const desktopFeedbackFlag = { | ||
| id: 'desktop_feedback', | ||
| env: 'KIMI_CODE_EXPERIMENTAL_DESKTOP_FEEDBACK', | ||
| title: 'Desktop feedback', | ||
| description: 'Enable global and reply feedback in the desktop app and web interface.', | ||
| default: false, | ||
| surface: 'core', | ||
| } satisfies FlagDefinitionInput; |
There was a problem hiding this comment.
Register the feedback flag in its owning module
When a session is produced by an agent-core entry point that does not import the KAP feedback routes, such as the CLI/TUI, the only registerFlagDefinition call never runs. FlagService.enabled('desktop_feedback') consequently remains false even when KIMI_CODE_EXPERIMENTAL_DESKTOP_FEEDBACK=1 or the master flag is set, so noteModel does not persist modelSteps; reopening that session in desktop/Web allows ratings but silently loses participating-model attribution. Register the definition from this flag module and remove the route-local registration.
AGENTS.md reference: AGENTS.md:L121-L124
Useful? React with 👍 / 👎.
Requirement or Bug
桌面应用和
kimi web的用户遇到问题时,可以从侧栏或输入框里的/feedback提交反馈,也可以直接评价一条回复。两种入口都允许用户选择是否附带会话记录。Bug Reproduction Steps
N/A
Root Cause
N/A
Code Changes
反馈由 KAP(Kimi Agent Protocol)先保存正文或评价并返回编号。客户端拿到编号后才提交用户选择的附件,因此可以单独重试失败项。设置
KIMI_CODE_EXPERIMENTAL_DESKTOP_FEEDBACK=1后可使用这些入口。flowchart LR UI["桌面 / Web 表单"] -->|正文或回复评价| KAP["KAP 反馈接口"] KAP -->|反馈编号| UI UI -->|选中的文件或会话| KAP KAP -->|分片传输| Storage["附件存储"]从
useDesktopFeedback.ts看入口、撤销与附件提交授权,从 KAP 的routes/feedback.ts看提交、更新、提交附件和准备远程会话归档的五条路由。conversationFeed.ts按回复匹配当时记录的模型和请求。服务端、客户端和两个界面放在同一个 PR,便于从正常入口验证整条提交链路。Screenshots / Recordings
全局表单和单条回复表单中,提交会话记录的选项默认关闭。
Behavior Changes and Affected Users
本地验证覆盖了表单提交、撤销、草稿、提交附件前的同意、失败重试和历史会话还原。附件可以在慢速连接上持续传输,直至完成或取消。对五条新增路由之外的 KAP 契约重新计算摘要,结果与基线一致。附件测试使用本地服务和示例数据。
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.