Fix recommendationList when a building max is reached#47
Merged
Mtarnuhal merged 2 commits intoMtarnuhal:masterfrom Oct 26, 2020
Merged
Fix recommendationList when a building max is reached#47Mtarnuhal merged 2 commits intoMtarnuhal:masterfrom
Mtarnuhal merged 2 commits intoMtarnuhal:masterfrom
Conversation
added 2 commits
October 25, 2020 20:21
to happen before building the array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
Changed so that instead of building the recommendation list, and then pulling the buildings out that have already hit their max, it excludes those buildings before calculating relative efficiency and building the list.
(Couple of little performance fixes as well)