Open
Conversation
8 tasks
|
all tests passed |
Contributor
|
ack, :LGTM: @leto |
|
all tests passed |
Member
Author
|
This needs tests before being merged to |
Contributor
|
Running any RPC tests as well as adding these new ones and testing them will require generating a new Regtest genesis block. |
Member
Author
|
@kentsommer a long time ago you pointed me at some repos where we could generate a valid regtest block and some explanation, would you mind sharing those again? |
Member
Author
|
Created #100 to track regtest genblock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 2 RPC methods which are useful for injecting and reading from memo fields
Bounty
25 HUSH for passing tests for both RPCs added in this PR
Start to manually merge zcash/zcash#2606