Skip to content

Refactor the array combination functions in CSSBlockList using array_push #1009

Open

Description

@oliverklee

… and the splat operator.

https://www.php.net/manual/en/function.array-push.php

We might need to raise the minimum PHP version first.

Activity

  1. JakeQZ commented on Feb 26, 2025

    @JakeQZ
    Collaborator

    … and the splat operator.

    We might need to raise the minimum PHP version first.

    PHP 7.2 is the minimum version in the main branch; this supports most splattable features, including being able to specify strict types. I don't expect we would need 'first class callables', which require PHP 8.1, and would I think be a bump too far. Some good information in answers here: https://stackoverflow.com/questions/41124015/what-is-the-meaning-of-three-dots-in-php.

  2. added a commit that references this issue on Mar 1, 2025
    e65c95f
  3. added 3 commits that reference this issue on Mar 1, 2025
    c905dc6
    5273c63
    6f14d83
  4. oliverklee commented on Mar 3, 2025

    @oliverklee
    CollaboratorAuthor

    We'll need at least PHP 7.3 for this - in #1045, the 7.2 unit tests are failing.

  5. JakeQZ commented on Mar 3, 2025

    @JakeQZ
    Collaborator

    We'll need at least PHP 7.3 for this - in #1045, the 7.2 unit tests are failing.

    This is presumably for array_push to be called with only one argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions