You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When parsing a rule or csslist, trailing comments (those comments after the rule/list) are consumed as part of a final consumeWhitespace call, meaning we don't see these reported for the next rule in the set (or the next set).
Consider the following cases:
div {/*Find Me!*/left:10px; /*Find Me Too!*/text-align:left;}
Both of these comments should be returned (one for each rule), but the latter is not.
/*Find Me!*/div {left:10px; text-align:left;} /*Find Me Too!*/a {left:10px;}
Both of these comments should be returned (one for each csslist), but the latter is not.
I'd like this fixed so I can use this to parse RTL directives for css rules/lists reliably again. Moodle recently upgraded to 8.3.0 and this broke our RTL.
Activity
Fix comment parsing to support multiple comments
[BUGFIX] Fix comment parsing to support multiple comments
[BUGFIX] Fix comment parsing to support multiple comments
[BUGFIX] Fix comment parsing to support multiple comments
[BUGFIX] Fix comment parsing to support multiple comments
[BUGFIX] Fix comment parsing to support multiple comments
[BUGFIX] Fix comment parsing to support multiple comments (MyInterval…
[BUGFIX] Fix comment parsing to support multiple comments (#671) (#671)
[BUGFIX] Fix comment parsing to support multiple comments
[BUGFIX] Fix comment parsing to support multiple comments (#672)
andrewnicols commentedon Mar 13, 2025
This should be reopened as #672 was reverted.
oliverklee commentedon Mar 13, 2025
Indeed, thanks! 🙏 Reopening.
[BUGFIX] Include comments for all rules in declaration block
[BUGFIX] Include comments for all rules in declaration block
[BUGFIX] Include comments for all rules in declaration block
[BUGFIX] Include comments for all rules in declaration block
[BUGFIX] Include comments for all rules in declaration block (#1182)
Catchup with upstream (#6)