Skip to content

Rework our class structure and naming to match the official specs #613

Open

Description

@oliverklee

https://www.w3.org/TR/cssom-1/
https://www.w3.org/TR/css-syntax-3/

We'll probably need to use PHP class aliases and deprecate a lot of things.

Activity

  1. added
    refactorFor PRs that refactor code without changing functionality
    on Jun 22, 2024
  2. added this to the 10.0.0 milestone on Jun 22, 2024
  3. JakeQZ commented on Jun 23, 2024

    @JakeQZ
    Collaborator

    I'm not so sure.

    The referenced documents are not an object model, but a syntax.

    Current class hierarchy seems to fit. At least for me. But, yes, please review.

  4. JakeQZ commented on Jun 26, 2024

    @JakeQZ
    Collaborator

    Actually, I think there are some misnomers. E.g. the current Rule\Rule class should be a Declaration or CssDeclaration in some namespace (ref). And the Rule and Property namespaces seem to be transposed from their current official definitions: a 'rule' is an enclosing block; a 'property' is a single value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    hacktoberfestrefactorFor PRs that refactor code without changing functionality

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions