Skip to content

[TASK] Add functional tests for Size parsing - #1711

Merged
JakeQZ merged 3 commits into
MyIntervals:mainfrom
IonBazan:test/functional-tests-size
Nov 16, 2026
Merged

JakeQZ merged 3 commits into
MyIntervals:mainfrom
IonBazan:test/functional-tests-size

Conversation

@IonBazan

Copy link
Copy Markdown
Contributor

Adds functional tests for Size parsing.

@coveralls

coveralls commented Nov 15, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 83.666% (+6.1%) from 77.585% — IonBazan:test/functional-tests-size into MyIntervals:main

@JakeQZ JakeQZ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've suggested a test method rename, and logged a potential issue highlighted by these additional tests. Thanks <3.

Comment thread tests/Functional/Value/SizeTest.php Resolved
Comment thread tests/Functional/Value/SizeTest.php Resolved
Comment thread tests/Functional/Value/SizeTest.php Resolved
@JakeQZ JakeQZ added the testing PRs/issues adding additional tests only, or primarily testing-focused label Nov 16, 2026
@IonBazan
IonBazan requested a review from JakeQZ November 16, 2026 11:44

@JakeQZ JakeQZ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent :).

@JakeQZ
JakeQZ merged commit 11e1273 into MyIntervals:main Nov 16, 2026
26 checks passed
@IonBazan
IonBazan deleted the test/functional-tests-size branch November 17, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing PRs/issues adding additional tests only, or primarily testing-focused

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants