Skip to content

[CLEANUP] Use common ancestor Value in type specifications - #507

Merged
oliverklee merged 2 commits into
mainfrom
cleanup/use-value-type
Mar 1, 2024
Merged

oliverklee merged 2 commits into
mainfrom
cleanup/use-value-type

Conversation

@JakeQZ

@JakeQZ JakeQZ commented Feb 28, 2024

Copy link
Copy Markdown
Collaborator

Replace the list of various possible sub-types with the common ancestor.

Update the class diagram to indicate that ValueList::$aComponents no longer has a dependency on the sub-types definitions.

Resolves #499. Supersedes and closes #506.

Replace the list of various possible sub-types with the common ancestor.

Update the class diagram to indicate that `ValueList::$aComponents` no longer
has a dependency on the sub-types definitions.

Resolves #499.  Supersedes and closes #506.
Comment thread README.md Resolved
@JakeQZ
JakeQZ requested a review from oliverklee February 29, 2024 18:42

@oliverklee oliverklee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oliverklee
oliverklee merged commit 086fa00 into main Mar 1, 2024
@oliverklee
oliverklee deleted the cleanup/use-value-type branch March 1, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide an interface for RuleValueList|CSSFunction|CSSString|LineName|Size|URL

2 participants