Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the prepare_renaming match to separate TODOs for bibkey and label renaming into distinct arms.
- Extracted
BibEntry(..)into its own arm with a bibkey TODO. - Grouped
Label(..)andContentRef(..)into a separate arm with a label TODO. - Preserved existing arms for other node types.
Myriad-Dreamin
force-pushed
the
rename-label
branch
from
bc99970 to
a85a190
Compare
Myriad-Dreamin
added a commit
that referenced
this pull request
Aug 26, 2025
This reverts commit 14c7a92.
Myriad-Dreamin
added a commit
that referenced
this pull request
Aug 26, 2025
Myriad-Dreamin
added a commit
that referenced
this pull request
Aug 26, 2025
Myriad-Dreamin
added a commit
that referenced
this pull request
Dec 8, 2025
Myriad-Dreamin
added a commit
that referenced
this pull request
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #549