Skip to content

feat(typlite): add support for image elements with byte sources#2202

Draft
hongjr03 wants to merge 3 commits intoMyriad-Dreamin:mainfrom
hongjr03:feat/image-bytes
Draft

feat(typlite): add support for image elements with byte sources#2202
hongjr03 wants to merge 3 commits intoMyriad-Dreamin:mainfrom
hongjr03:feat/image-bytes

Conversation

@hongjr03
Copy link
Contributor

@hongjr03 hongjr03 commented Oct 28, 2025

Previously, we assumed that the src argument of image could only be a path string so the image.decode case was ignored. Now we’ve added a show rule that wraps images in bytes inside an html.frame allowing all kinds of images to be embedded.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hongjr03, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the typlite project by enabling the processing and rendering of image elements directly from byte arrays. This feature provides greater flexibility for embedding images that might not originate from a file path, such as dynamically generated graphics or in-memory data. The changes involve modifications to the Typst rendering logic, the internal HTML parsing mechanism, and the addition of new test cases to validate the functionality across different output formats.

Highlights

  • Support for Byte-Sourced Images: The system now recognizes and processes images whose source is provided as raw bytes, enabling more flexible image embedding directly from memory or dynamic generation.
  • Dynamic Image Handling: Images provided as bytes are converted to SVG format and then either saved as external files (if an asset path is configured) or embedded directly into the output as base64 data URLs.
  • New HTML Tag m1imagebytes: A dedicated internal HTML element m1imagebytes has been introduced to specifically differentiate and handle byte-sourced images during the conversion process.
  • Updated md-image Function: The md-image function in markdown.typ has been enhanced to detect when an image source is provided as bytes and route it to the new specialized handling logic.
  • Comprehensive Testing: New integration tests and snapshot tests have been added to ensure the correct rendering and conversion of byte-sourced images in both Markdown and LaTeX outputs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for image elements with byte sources, which is a great feature for embedding images directly. The implementation is mostly solid, with changes across Typst scripts and Rust parser code to handle this new image source type. I've identified a couple of areas for improvement. In the Typst code, there's a minor issue with how path-based images are handled that could lead to confusion. In the Rust parser, the new function for handling byte-sourced images can be refactored to improve readability and reduce code duplication. My detailed comments provide specific suggestions for these points.

@hongjr03 hongjr03 marked this pull request as draft October 28, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments