feat(typlite): add support for image elements with byte sources#2202
feat(typlite): add support for image elements with byte sources#2202hongjr03 wants to merge 3 commits intoMyriad-Dreamin:mainfrom
Conversation
Summary of ChangesHello @hongjr03, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for image elements with byte sources, which is a great feature for embedding images directly. The implementation is mostly solid, with changes across Typst scripts and Rust parser code to handle this new image source type. I've identified a couple of areas for improvement. In the Typst code, there's a minor issue with how path-based images are handled that could lead to confusion. In the Rust parser, the new function for handling byte-sourced images can be refactored to improve readability and reduce code duplication. My detailed comments provide specific suggestions for these points.
Previously, we assumed that the
srcargument ofimagecould only be a path string so theimage.decodecase was ignored. Now we’ve added a show rule that wraps images in bytes inside anhtml.frameallowing all kinds of images to be embedded.