feat: configure extension that handlers document preview#2357
feat: configure extension that handlers document preview#2357Myriad-Dreamin wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @Myriad-Dreamin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility of the Tinymist VS Code extension's preview capabilities by introducing a new configuration option. Users can now specify an external extension to handle preview rendering, decoupling the core extension from specific preview implementations. This change paves the way for integrating more experimental or specialized preview features, such as WebGL-based rendering or custom thematic presentations, without requiring modifications to the main extension, thereby promoting modularity and innovation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration setting, tinymist.previewExtension, which is intended to allow users to specify an external VS Code extension for the document preview. The changes include adding the configuration to package.json and providing English and Chinese localization for its title and description.
While the configuration is correctly defined, the implementation to use this setting within the VS Code extension appears to be missing. For the feature to be complete, the extension code needs to read this configuration and load the specified preview extension. I've added a specific comment regarding this.
| "tinymist.previewExtension": { | ||
| "title": "%extension.tinymist.config.tinymist.previewExtension.title%", | ||
| "markdownDescription": "%extension.tinymist.config.tinymist.previewExtension.desc%", | ||
| "type": "string", | ||
| "default": "myriad-dreamin.tinymist" | ||
| }, |
There was a problem hiding this comment.
This change adds the tinymist.previewExtension configuration, but the logic to use this setting seems to be missing in the extension's code. For this feature to work, the extension needs to read this configuration value and, if an external extension is specified, activate or interact with it for the preview functionality. For example, in editors/vscode/src/extension.ts, the previewActivateInTinymist function would need to be updated to handle this new configuration.
This PR adds a
tinymist.previewExtensionconfiguration item to get a different frontend implementation from the extension.With this configuration, we can bravely add some break change or experimental features in the different frontend implementation. For example: