Skip to content

Comments

feat: configure extension that handlers document preview#2357

Draft
Myriad-Dreamin wants to merge 1 commit intomainfrom
configure-preview-extension
Draft

feat: configure extension that handlers document preview#2357
Myriad-Dreamin wants to merge 1 commit intomainfrom
configure-preview-extension

Conversation

@Myriad-Dreamin
Copy link
Owner

@Myriad-Dreamin Myriad-Dreamin commented Jan 17, 2026

This PR adds a tinymist.previewExtension configuration item to get a different frontend implementation from the extension.

tinymist.previewExtension is the name of a VS Code extension to customize preview, like hardware-accelerated rendering or previewing with a different theme. If not set, the extension will use the embedded preview feature. The default value is myriad-dreamin.tinymist (the main tinymist extension).

With this configuration, we can bravely add some break change or experimental features in the different frontend implementation. For example:

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Myriad-Dreamin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the flexibility of the Tinymist VS Code extension's preview capabilities by introducing a new configuration option. Users can now specify an external extension to handle preview rendering, decoupling the core extension from specific preview implementations. This change paves the way for integrating more experimental or specialized preview features, such as WebGL-based rendering or custom thematic presentations, without requiring modifications to the main extension, thereby promoting modularity and innovation.

Highlights

  • New Configuration Item: Introduced a new configuration item, tinymist.previewExtension, allowing users to specify an external VS Code extension for preview customization.
  • External Preview Flexibility: This new setting enables the use of different frontend implementations for the preview feature, supporting advanced capabilities like hardware-accelerated rendering or custom themes.
  • Default Behavior: If tinymist.previewExtension is not explicitly set, the extension will default to using its embedded preview functionality. The default value for this configuration is myriad-dreamin.tinymist.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration setting, tinymist.previewExtension, which is intended to allow users to specify an external VS Code extension for the document preview. The changes include adding the configuration to package.json and providing English and Chinese localization for its title and description.

While the configuration is correctly defined, the implementation to use this setting within the VS Code extension appears to be missing. For the feature to be complete, the extension code needs to read this configuration and load the specified preview extension. I've added a specific comment regarding this.

Comment on lines +750 to +755
"tinymist.previewExtension": {
"title": "%extension.tinymist.config.tinymist.previewExtension.title%",
"markdownDescription": "%extension.tinymist.config.tinymist.previewExtension.desc%",
"type": "string",
"default": "myriad-dreamin.tinymist"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change adds the tinymist.previewExtension configuration, but the logic to use this setting seems to be missing in the extension's code. For this feature to work, the extension needs to read this configuration value and, if an external extension is specified, activate or interact with it for the preview functionality. For example, in editors/vscode/src/extension.ts, the previewActivateInTinymist function would need to be updated to handle this new configuration.

@Myriad-Dreamin Myriad-Dreamin changed the title feat: configure external preview extension feat: configure extension that handlers document preview Jan 17, 2026
@Myriad-Dreamin Myriad-Dreamin marked this pull request as draft January 17, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant