feat: code action for wrapping block in figure with caption#2367
feat: code action for wrapping block in figure with caption#2367QuadnucYard wants to merge 7 commits intoMyriad-Dreamin:mainfrom
Conversation
Summary of ChangesHello @QuadnucYard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the code action capabilities by introducing a new refactoring option to wrap selected content in a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new code action feature that allows users to wrap various block types (function calls like image, table, raw, code blocks, content blocks, and raw blocks) within a figure environment, with options to place the caption before or after the content. The implementation correctly handles different syntax kinds and determines whether a hash prefix is needed for raw blocks based on context. The new localization strings for these actions are also included. I've identified a couple of areas for improvement regarding snippet cursor placement and minor code clarity. Additionally, I noticed the inclusion of exportHtml and exportPdf localization keys, which seem unrelated to the primary feature of this PR.
Supports:
image,table,raw(matched by name only)