TilesRenderer: Handle ending raycast traversal early#546
Merged
Conversation
|
Sorry, changed the logic in mrdoob/three.js#28520 🙏 |
Contributor
Author
|
Thanks I'll make a new release once r165 is out |
This was referenced May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #416
Related to mrdoob/three.js#27709
If a three.js version greater than r165 then we can use the new ability to exit raycast traversal early (mrdoob/three.js#27709) which will improve performance and allow for custom raycast functions.
Raycasting in an extreme case (close mesh, error target of 10) results in improvements from ~1.8-2.1ms to ~0.2ms for a raycast.
TODO
cc @AlaricBaraou