Add capgen automated testing on PRs to "develop"#577
Merged
Conversation
peverwhee
requested review from
climbfuji,
dustinswales,
gold2718,
grantfirl,
mkavulich and
mwaxmonsky
as code owners
gold2718
approved these changes
Jul 15, 2024
gold2718
left a comment
gold2718
left a comment
Collaborator
There was a problem hiding this comment.
Great, now can we make develop the default branch for opening PRs? :)
Collaborator
Author
@gold2718 I'll add an item to our next framework meeting agenda - I think making PRs default to "develop" will also make "develop" the default branch overall and I'm not sure "we" want to do that! |
Collaborator
Yeah, the smiley face is because I think we do not want develop to be the default branch. |
dustinswales
approved these changes
Jul 15, 2024
climbfuji
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the github workflows so capgen tests run when a PR is opened into the "develop" branch (in addition to the "main" branch)
User interface changes?: No