Constituent bugfixes#608
Merged
peverwhee merged 10 commits intoNCAR:developfrom Nov 5, 2024
Merged
Conversation
Collaborator
|
I approve (still no "approve" button on my machine) |
dustinswales
approved these changes
Nov 1, 2024
mwaxmonsky
approved these changes
Nov 5, 2024
Collaborator
mwaxmonsky
left a comment
There was a problem hiding this comment.
Thanks for taking care of this @peverwhee, looks great to me!
mkavulich
pushed a commit
that referenced
this pull request
Nov 7, 2024
Fixes bug introduced by me in #608. Use variable errflg name instead of "errflg" explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of small bugs in the constituents object
User interface changes?: No
Fixes #587
Testing:
test removed: N/A
unit tests: All pass
system tests: All pass; modified advection test to check new instantiate fields
manual testing: Run w/ register phase in CAM-SIMA