DRAFT: New test to demonstrate GNU failure#689
DRAFT: New test to demonstrate GNU failure#689dustinswales wants to merge 88 commits intoNCAR:developfrom
Conversation
Update main with develop branch
…an modules in the correct place (#4) Update CMakeLists.txt to: - Bring in updates from NCAR ccpp-framework main as needed and update CMakeLists.txt to modern cmake version 3 - Support NEPTUNE cmake build while retaining compatibility with UFS/SCM
…an modules in the correct place (NCAR#653) **Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place** Update CMakeLists.txt to modern cmake version 3 and support NEPTUNE cmake build while retaining compatibility with UFS/SCM User interface changes?: No Fixes: [Github issue #s] n/a Testing: all CI tests pass, ran `capgen` and `prebuild` tests locally on my laptop - all pass test removed: unit tests: system tests: manual testing: Associated PRs: - ccpp-physics: ufs-community/ccpp-physics#259 - FV3: NOAA-EMC/ufsatm#940 - ufs-weather-model: ufs-community/ufs-weather-model#2659
… feature/pull_in_dev_20250724
… feature/pull_in_dev_20250724
dustinswales
requested review from
climbfuji,
gold2718,
grantfirl,
mkavulich,
mwaxmonsky and
peverwhee
as code owners
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Can this PR be prioritized so that we can work towards a solution?
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Obviously, we can't merge this because it breaks the CI tests. Is the intention to keep this PR open until a fix is in place and the test passes?
Fair. I suppose I can always cut a branch from this PR branch if I want to play with the problem. |
Correct, and we'll keep this branch up to date with develop so that you can always pull that in, too. |
dustinswales
changed the title
…up_TMP" This reverts commit 41dedc8.
… bug/unalloc_var_to_Group
climbfuji
force-pushed
the
bug/unalloc_var_to_Group
branch
from
c3ec858 to
8088179
Compare
…/ccpp-framework into bug/unalloc_var_to_Group_dom_cleanup
add more testing to advection test
…wales/ccpp-framework into bug/unalloc_var_to_Group_dom_cleanup
…varname=True and remove unnecessary logic
| 'scheme_files':'', | ||
| 'suites':''}) | ||
|
|
||
| # DH* MOVE THIS ELSEWHERE |
There was a problem hiding this comment.
Note. With my latest updates, all this will be removed again - existing functionality suffices!
…wales/ccpp-framework into bug/unalloc_var_to_Group_dom_cleanup
…wales/ccpp-framework into bug/unalloc_var_to_Group_dom_cleanup
|
@dustinswales I updated your branch from |
…er variable declarations
…p-framework into bug/unalloc_var_to_Group_dom_cleanup
…eanup bug/unalloc_var_to_group Dom cleanup
6 participants
New test to demonstrate GNU failure when passing unallocated fields into the Group cap.
See error HERE
This test will be added when (?) we move to pass host DDTs into suite Caps
User interface changes?: No
Related to #690
Testing:
test removed:
unit tests:
system tests:
manual testing: