fix bug in calculate_coverage()#260
Open
jeffreyhanson wants to merge 1 commit into
Open
Conversation
this bug means that NA values are returned if a theme/weight/include only has 0s it will also cause the app to crash if a theme/weight/include only has 0s
Contributor
|
Thanks @jeffreyhanson , I will give this a look. It shouldn't conflict with any of the |
Contributor
Author
|
Awesome! Great to hear it works - no worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @DanWismer,
I got an email about the WTW tool crashing when a user was trying to upload a shapefile. It turned out some of their columns in the attribute table only had zero; which caused a divide by zero calculation; resulting in NaN values for certain variables that shouldn't have NA values; and, in turn, crashing the app. This PR fixes the bug and means the app should now work with features that only contain zeros. When you get a chance, could you please review it and merge into the mian branch? Although the fix is super minor - I don't want to cause any merge issues with the stuff you've been working on, so I thought it best not to merge immediately. Let me know if you have any questions?