DS-780 Apply Ruff to Application Folder #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JackPlowman
force-pushed
the
task/DS-780_Application_Ruff_Implementation
branch
from
0335476 to
c17aa8e
Compare
JackPlowman
changed the title
JackPlowman
force-pushed
the
task/DS-780_Application_Ruff_Implementation
branch
from
7c6754d to
384a531
Compare
mabe13
reviewed
May 16, 2023
mabe13
reviewed
May 16, 2023
mabe13
reviewed
May 16, 2023
mabe13
reviewed
May 16, 2023
Collaborator
mabe13
left a comment
mabe13
left a comment
There was a problem hiding this comment.
Added two comments about checking a commented function and it's test are meant to be deleted. Another than that happy for this one to be merged
added 2 commits
May 17, 2023 09:22
|
Kudos, SonarCloud Quality Gate passed! |
mabe13
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Branch Pull Request
https://nhsd-jira.digital.nhs.uk/browse/DS-780
Description of Changes
This PR updates all files in the Application folder to meet Ruff standards.