DS-845 Remove GitHub Warnings and More Ruff Refactoring #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPlowman
force-pushed
the
task/DS-845_Remove_GitHub_Warnings
branch
3 times, most recently
from
d125ee5 to
6a7861b
Compare
JackPlowman
force-pushed
the
task/DS-845_Remove_GitHub_Warnings
branch
2 times, most recently
from
5885401 to
998902a
Compare
JackPlowman
force-pushed
the
task/DS-845_Remove_GitHub_Warnings
branch
from
998902a to
1ede328
Compare
added 2 commits
May 31, 2023 09:42
JackPlowman
force-pushed
the
task/DS-845_Remove_GitHub_Warnings
branch
from
1ede328 to
e47032b
Compare
mabe13
previously approved these changes
May 31, 2023
|
Kudos, SonarCloud Quality Gate passed! |
mabe13
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Branch Pull Request
https://nhsd-jira.digital.nhs.uk/browse/DS-845
Description of Changes
This PR adds Ruff refactoring to more service sync files. As well as removing GitHub maintainability warnings.