PPHA-529: Add smoked total years for cigarettes smoking type#250
Merged
Themitchell merged 2 commits intomainfrom Feb 3, 2026
Merged
PPHA-529: Add smoked total years for cigarettes smoking type#250Themitchell merged 2 commits intomainfrom
Themitchell merged 2 commits intomainfrom
Conversation
Themitchell
force-pushed
the
PPHA-534-smoked-total-years
branch
from
4d2932f to
fc78754
Compare
jamiefalcus
reviewed
Feb 2, 2026
lung_cancer_screening/questions/tests/unit/forms/test_smoked_total_years_form.py
Show resolved
Hide resolved
Themitchell
force-pushed
the
PPHA-534-smoked-total-years
branch
from
fc78754 to
ca650d8
Compare
Themitchell
changed the title
Ensure that the smoked total years for a type of tobacco cannot be longer than the overall total years smoked based on their age when started
Themitchell
force-pushed
the
PPHA-534-smoked-total-years
branch
from
ca650d8 to
72739e1
Compare
|
jamiefalcus
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Add smoked total years for the cigarette smoking type with the view to ensuring the journey is conpatible with other smoking types later
Why are we making this change?
As part of participants telling us a detailed history of their smoking per each type of smoking
Screenshots