[NDR-288] Provide fhir upload nhs id error details#926
Merged
megan-bower4 merged 6 commits intomainfrom Jan 19, 2026
Merged
Conversation
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
force-pushed
the
NDR-288
branch
from
423f37b to
2bde5af
Compare
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
force-pushed
the
NDR-288
branch
from
2bde5af to
8fce7cb
Compare
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
had a problem deploying
to
development
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
development
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
development
GitHub Actions
Failure
megan-bower4
changed the title
tim-knight-nhs
previously approved these changes
Jan 13, 2026
PedroSoaresNHS
previously approved these changes
Jan 15, 2026
lillie-dae
previously approved these changes
Jan 15, 2026
NogaNHS
reviewed
Jan 15, 2026
NogaNHS
reviewed
Jan 15, 2026
megan-bower4
dismissed stale reviews from lillie-dae, PedroSoaresNHS, and tim-knight-nhs
via
f9c23c2
megan-bower4
had a problem deploying
to
development
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
development
GitHub Actions
Failure
tim-knight-nhs
previously approved these changes
Jan 16, 2026
lillie-dae
previously approved these changes
Jan 16, 2026
megan-bower4
dismissed stale reviews from lillie-dae and tim-knight-nhs
via
9db7de4
megan-bower4
had a problem deploying
to
development
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
development
GitHub Actions
Failure
Code security issues foundView full details here. |
tim-knight-nhs
approved these changes
Jan 16, 2026
|
lillie-dae
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: NDR-288
Description
This change allows an optional details parameter to be passed to LambdaError. This gives the chance to provide additional details if necessary.
It is utilised for providing additional context when there is an fhir upload error due to an invalid formatted NHS number.
Context
The apigateway response on post fhir document reference was not very useful when an invalid formatted NHS number was given. This change allows the details to be presented to the user, without the need to dig into lambda logs/errors.
Checklist
Tasks for all changes:
Deploy - Sandbox- workflow runSANDBOX Full- Deploy feature branch to sandbox- workflow run