Skip to content

Added W3CExtendedLogLayout for writing W3C Extended Logs#700

Merged
snakefoot merged 1 commit into
NLog:masterfrom
snakefoot:W3CLoggerLayout
Oct 28, 2021
Merged

Added W3CExtendedLogLayout for writing W3C Extended Logs#700
snakefoot merged 1 commit into
NLog:masterfrom
snakefoot:W3CLoggerLayout

Conversation

@snakefoot

@snakefoot snakefoot commented Sep 26, 2021

Copy link
Copy Markdown
Contributor

Activate RequestMiddleware like this:

        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
           ...
           app.UseMiddleware<NLog.Web.RequestLoggingMiddleware>();
           ...
        }

Enable W3C Log-File like this in NLog.config:

<nlog throwConfigExceptions="true">
  <extensions>
    <add assembly="NLog.Web.AspNetCore"/>
  </extensions>
  <targets>
    <target file="w3c-file" filename="W3C-Requests.log">
         <layout type="W3CExtendedLogLayout"/>
    </target>
  </targets>
  <rules>
     <logger name="NLogRequestLogging" minLevel="Debug" writeTo="w3c-file" final="true" />
  </rules>
</nlog>

Available W3C log-parsers:

@snakefoot snakefoot added this to the 5.0 milestone Sep 26, 2021
@codecov-commenter

codecov-commenter commented Sep 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #700 (0ec75b0) into master (b98cd07) will decrease coverage by 3%.
The diff coverage is 55%.

❗ Current head 0ec75b0 differs from pull request most recent head 43dda2d. Consider uploading reports for the commit 43dda2d to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##           master   #700    +/-   ##
======================================
- Coverage      64%    62%    -3%     
======================================
  Files          38     45     +7     
  Lines         581    780   +199     
  Branches      140    183    +43     
======================================
+ Hits          374    482   +108     
- Misses        157    235    +78     
- Partials       50     63    +13     
Impacted Files Coverage Δ
...tRenderers/AspNetApplicationValueLayoutRenderer.cs 75% <ø> (ø)
src/NLog.Web/NLogRequestLoggingModule.cs 0% <0%> (ø)
...b/Targets/Wrappers/AspNetBufferingTargetWrapper.cs 0% <0%> (ø)
...LayoutRenderers/AspNetAppBasePathLayoutRenderer.cs 0% <ø> (ø)
.../Shared/LayoutRenderers/AspNetMvcActionRenderer.cs 40% <ø> (ø)
...red/LayoutRenderers/AspNetMvcControllerRenderer.cs 40% <ø> (ø)
...enderers/AspNetRequestContentTypeLayoutRenderer.cs 0% <ø> (ø)
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 87% <ø> (ø)
...LayoutRenderers/AspNetRequestFormLayoutRenderer.cs 94% <ø> (ø)
...outRenderers/AspNetRequestHeadersLayoutRenderer.cs 81% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be7d6d...43dda2d. Read the comment docs.

@snakefoot snakefoot force-pushed the W3CLoggerLayout branch 3 times, most recently from 1f44baf to 0c804d4 Compare September 27, 2021 20:01
@snakefoot snakefoot changed the title Added W3CLoggerLayout for writing W3C Extended Logs Added W3CExtendedLogLayout for writing W3C Extended Logs Sep 27, 2021
@snakefoot

snakefoot commented Sep 29, 2021

Copy link
Copy Markdown
Contributor Author

Further optimizations can be made when NLog 5.0-preview2 is out:

@304NotModified 304NotModified changed the title Added W3CExtendedLogLayout for writing W3C Extended Logs Added W3CExtendedLogLayout for writing W3C Extended Logs and added ${aspnet-request-duration} Oct 2, 2021
Comment thread src/NLog.Web.AspNetCore/NLogRequestLoggingMiddleware.cs
Comment thread src/NLog.Web.AspNetCore/NLogRequestLoggingMiddleware.cs Outdated
Comment thread src/NLog.Web/NLogRequestLoggingModule.cs Outdated
Comment thread src/NLog.Web/NLogRequestLoggingModule.cs Outdated
Comment thread src/Shared/LayoutRenderers/AspNetRequestDurationLayoutRenderer.cs
Comment thread src/Shared/LayoutRenderers/AspNetRequestDurationLayoutRenderer.cs
Comment thread src/Shared/LayoutRenderers/AspNetRequestDurationLayoutRenderer.cs
Comment thread src/Shared/LayoutRenderers/AspNetRequestDurationLayoutRenderer.cs
Comment thread src/Shared/LayoutRenderers/AspNetRequestDurationLayoutRenderer.cs
@pull-request-size pull-request-size Bot added size/L and removed size/XL labels Oct 6, 2021
@snakefoot snakefoot changed the title Added W3CExtendedLogLayout for writing W3C Extended Logs and added ${aspnet-request-duration} Added W3CExtendedLogLayout for writing W3C Extended Logs Oct 6, 2021
@snakefoot snakefoot force-pushed the W3CLoggerLayout branch 8 times, most recently from 7ff5c8e to ffabf3b Compare October 6, 2021 22:59
@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Oct 6, 2021
@snakefoot snakefoot force-pushed the W3CLoggerLayout branch 6 times, most recently from 0a7643b to fda9144 Compare October 7, 2021 21:23
@snakefoot snakefoot closed this Oct 28, 2021
@snakefoot snakefoot reopened this Oct 28, 2021
@snakefoot snakefoot closed this Oct 28, 2021
@snakefoot snakefoot reopened this Oct 28, 2021
@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

78.0% 78.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit 4977cab into NLog:master Oct 28, 2021
@snakefoot

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants