Draft
Conversation
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test 4d4fc31 |
Contributor
Author
|
/ok to test 8c6826b |
Contributor
Author
|
/ok to test b5f2606 |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test f281b65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
_maybe_build_consolidated_index: filters the finalfqn_to_file_index_mappingto only include keys actually present in the state_dict being saved. This removes phantom_blocks/_scaleskeys from the base checkpoint index when saving dequantized bf16 weights._parse_input_metadata: after populating output file data from input shards, removes any FQNs that still have an emptydtype_str(meaning they weren't found in any input shard). Logs a warning to make the mismatch visible.TestBuildConsolidatedIndexQuantizedBase::test_stale_quantized_keys_are_filtered- verifies_blocks/_scaleskeys don't leak into the mappingTestBuildConsolidatedIndexQuantizedBase::test_new_keys_assigned_to_last_shard- verifies new keys get the default shard indexTestConsolidationWithPhantomKeys::test_consolidated_safetensors_loadable_with_phantom_keys- end-to-end: creates DCP shard files, runs consolidation with phantom keys, verifies the output is loadable with safe_open and contains correct tensorsTestConsolidationWithPhantomKeys::test_consolidated_safetensors_no_phantom_keys- regression test: consolidation without phantom keys works as beforeChangelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information