Open
Conversation
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
jmabry
reviewed
Mar 12, 2026
|
|
||
| - **Understand your changes**: You must be able to explain and debug every line in your PR. Treat AI output as code from an untrusted source that requires your review. | ||
| - **Self-review and test**: Before requesting review, read through the diff carefully, run the test suite (`pytest`), and run pre-commit checks locally. Never treat AI-generated code as ready to merge without your own verification. | ||
| - **Keep PRs focused**: AI tools sometimes make "drive-by improvements" to unrelated code. Strip out any changes that are not directly relevant to the task at hand. |
There was a problem hiding this comment.
What about document any needed drive-by enhancements as an issue?
jmabry
requested changes
Mar 12, 2026
jmabry
left a comment
jmabry
left a comment
There was a problem hiding this comment.
Documentation appears in triplicate. Possible to reference a single-source of truth so that is more DRY in any secondary docs?
| ```bash | ||
| git commit -s -S -m "Add reward function for code evaluation | ||
|
|
||
| Assisted-by: GitHub Copilot" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement PR for: #662
Contributors: @lbliii
first pass at guidelines for AI-enabled contributions. Open to all ideas/suggestions.