Skip to content

[automodel] remove unused cell in multinode notebook#12624

Merged
ko3n1g merged 1 commit into
mainfrom
yz/dev/fix-multinode-notebook
Mar 25, 2025
Merged

[automodel] remove unused cell in multinode notebook#12624
ko3n1g merged 1 commit into
mainfrom
yz/dev/fix-multinode-notebook

Conversation

@yuanzhedong

Copy link
Copy Markdown
Contributor

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@yuanzhedong yuanzhedong requested review from BoxiangW and akoumpa March 16, 2025 04:26
Comment thread tutorials/llm/automodel/multinode.ipynb
Signed-off-by: Yuanzhe Dong <yudong@nvidia.com>
@akoumpa akoumpa force-pushed the yz/dev/fix-multinode-notebook branch from 751eabf to 5d3a69f Compare March 23, 2025 02:51
@akoumpa akoumpa added the documentation Improvements or additions to documentation label Mar 23, 2025
@akoumpa

akoumpa commented Mar 23, 2025

Copy link
Copy Markdown
Collaborator

@ko3n1g @chtruong814 can we merge without running full CI?

@ko3n1g ko3n1g merged commit 2fbf307 into main Mar 25, 2025
@ko3n1g ko3n1g deleted the yz/dev/fix-multinode-notebook branch March 25, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants